element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.05k stars 1.97k forks source link

cmd-` as a keyboard shortcut on macOS hijacks the OS shortcut for switching between windows of an app #14381

Open ara4n opened 4 years ago

ara4n commented 4 years ago

this is pretty bad form; it's almost as bad as overloading cmd-tab

tedd4u commented 3 years ago

Backtick to preferences shortcut appears to be defined at line 204 of this file:

https://github.com/matrix-org/matrix-react-sdk/blob/8a0ee2fd34adfd5d7cdd03e625284458892f427a/src/accessibility/KeyboardShortcuts.tsx#L204

SimonBrandner commented 3 years ago

No, it's actually defined here. The file you linked just defines what is shown in the dialog that lists the keybindings. In the future, that dialog should be replaced by one that reads the keybindings directly from the file where they are defined