element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.14k stars 1.98k forks source link

IRC-style layout should have a more "rigid grid" #14940

Open eyalroz opened 4 years ago

eyalroz commented 4 years ago

Description

In the Appearance settings, we can choose an "IRC style layout". This is an improvement, but it's really not there yet:

Version information

Desktop.

For the desktop app:

t3chguy commented 4 years ago

Perhaps just rectangular backgrounds for nicknames; perhaps a font color change; perhaps just a :hover effect.

These are not hugely accessible options.

The message "viewport" must not be able to display a non-integral number of lines, i.e. must not be able to cut lines in the middle at the top or bottom of the viewport.

Do you suggest scrolling in number of messages? That would feel hugely stuttery for longer/shorter message mix.

eyalroz commented 4 years ago

These are not hugely accessible options.

I am not an expert on accessibility. But - in principle, there is probably some measure contradiction between "IRC mode" and "respecting accessibility". It's not clear that a compromise is the correct solution; perhaps two options/submodes? I'm not sure. I just know that to enable an IRC-like experience, the balloons are a problem. If you do want some sort of "fairness" - dropping balloons altogether would work...

The message "viewport" must not be able to display a non-integral number of lines, i.e. must not be able to cut lines in the middle at the top or bottom of the viewport.

Do you suggest scrolling in number of messages? That would feel hugely stuttery for longer/shorter message mix.

No, I didn't say messages, I said lines. In IRC mode, any content - messages or anything else - can't be cut off in mid-line. Especially not a part-of-a-message-line.

t3chguy commented 4 years ago

Okay but not everything is in a number of lines, e.g images/videos. Audio playback is actually sized by your browser.

eyalroz commented 4 years ago

Okay but not everything is in a number of lines, e.g images/videos. Audio playback is actually sized by your browser.

Oh, that's part of what needs to be fixed. In IRC, those should be at most pop-ups with images/buttons/links that fit within a single line. No multi-line blocks even. ... so that it'll look more like IRC, not "compact Slack".