search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.15k stars 1.99k forks source link

The light-custom and dark-custom themes still use the now-replaced Nunito fonts? #15095

Open fooness opened 4 years ago

fooness commented 4 years ago

This one took me quite some time to figure out … while the light and dark theme use font-family: Inter, …, the light-custom and dark-custom themes still use the now-replaced Nunito font …

https://github.com/matrix-org/matrix-react-sdk/blob/develop/res/themes/light-custom/css/light-custom.scss#L3

https://github.com/matrix-org/matrix-react-sdk/blob/develop/res/themes/legacy-light/css/_fonts.scss#L17-L34

Can this please be updated as well? Thank you.

t3chguy commented 4 years ago

I believe it was intentional to not affect any existing themes.

fooness commented 4 years ago

In my humble opinion, if the custom themes won’t be changed and adapted, then custom theming won’t improve. I don’t see any advantages here. I strongly believe that anyone who uses custom theming and has created their own custom themes is looking forward to improvement of custom theming.

(Custom) Theming is nothing you do once and you’re done. Finished. Things will change, things will break, things will be improved. We shouldn’t keep legacy and outdated and buggy code just because someone might be using it and we’re afraid to make them adapt their themes and, in the end, deliver them a better experience and more possibilities and features.

From another side of view, anyone who just starts using Element and wants to create their first custom theme, they will be presented the legacy theme and that’s just confusing. They probably want to change the default theme they’re seeing, but if changing some colors then automatically changes the overall appearance of the theme … that’s just unexpected and weird.

turt2live commented 4 years ago

The custom themes are specifically pinned to the legacy themes due to compatibility and time constraints. The idea is to port it over to the new themes eventually.