search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.23k stars 2k forks source link

Reactions aren't rendered on refresh in E2EE rooms when "Show hidden events in timeline" labs option enabled #15496

Open non-Jedi opened 4 years ago

non-Jedi commented 4 years ago

Description

When the "Show hidden events in timeline" labs option is enabled, reactions aren't rendered in E2EE rooms upon initial refresh of riot-web.

Steps to reproduce

  1. React to a message in an E2EE room.
  2. Refresh riot-web page in browser.
  3. Reaction will not be rendered under the message reacted to.
  4. Navigate to another room and then back again.
  5. Reaction will now be rendered.

Logs being sent: no

Version information

For the web app:

turt2live commented 4 years ago

cannot current reproduce, thought is it might be encrypted room specific.

non-Jedi commented 4 years ago

I've updated the OP with steps to reproduce.

t3chguy commented 4 years ago

I can reproduce using the above steps. Disabling the labs flag makes the issue go away

looks like a missing state update + race condition as it knows it has the reaction

image