search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.23k stars 2k forks source link

Consider a larger health warning when trying to search an e2e room on web. #15715

Open neilisfragile opened 4 years ago

neilisfragile commented 4 years ago

Anecdotally it is easy to miss the warning in the search bar when trying to search via the web client in an e2e room. So users assume that our search is simply broken.

Would it make more sense to prevent the search box appearing (with explanation) at all on clicking the search icon? Or at least have a louder warning on clicking the search icon?

A reason not to do this would be if the user wanted to search all rooms (rather than current room) so it might be worth understanding how users search today before deciding one way or the other.

t3chguy commented 4 years ago

Preventing search from appearing would be bad as not all rooms begin life as encrypted, not all rooms only contain encrypted content.

MadLittleMods commented 4 years ago

The hint is easy to miss when most of the page is blank. Can we duplicate some information down to the "No results" to explain that you won't get any results in the web client for an encrypted room?

aaronraimist commented 4 years ago

Preventing search from appearing would be bad as not all rooms begin life as encrypted, not all rooms only contain encrypted content.

Is there any way to check if a room has been encrypted since it was created and disable search in that case? By comparing the timestamp of m.room.create and m.room.encryptionor something

Surely at least for rooms created after E2E by default happened the vast majority of encrypted rooms have been encrypted since they were created.

t3chguy commented 4 years ago

Additionally fixing the warning to not tell the user to use the Desktop app if they already are but it is broken would be great.

richvdh commented 4 years ago

why does the "Use the Desktop app to search encrypted messages" warning pop up even when I am searching from the desktop app?

t3chguy commented 4 years ago

@richvdh

why does the "Use the Desktop app to search encrypted messages" warning pop up even when I am searching from the desktop app?

Additionally fixing the warning to not tell the user to use the Desktop app if they already are but it is broken would be great.

Because your build is either lacking Seshat or Seshat failed to build. Either the index is broken or you're missing sqlcipher

Amcio commented 3 years ago

Because your build is either lacking Seshat or Seshat failed to build.

Is there any information on what to do in that case? Or do I have to compile it on my own at that point? (Windows) I tried the nightly build but the same thing happens.

Update: Managed to find an issue about it. Deleted EventStore folder and now it works. I will leave this comment for future reference.

paul90 commented 3 years ago

Having the warning when trying to search using the web client is too late. There needs to be a warning when a room is being created that E2EE rooms can't be searched with the web client.

Effectively #2548 only partially solves client-side search for E2EE rooms, effectively not providing a solution for those that can't use the desktop client for whatever reason.