Make chat effects more deterministic

element-hq / element-web

A glossy Matrix collaboration client for the web.

https://element.io

GNU Affero General Public License v3.0

11.19k stars 2k forks source link

Make chat effects more deterministic #16015

Open turt2live opened 3 years ago

turt2live commented 3 years ago

Currently sending multiple emojis which would trigger multiple effects only triggers one on the sender side, but the receiver sees multiple. This is likely due to the handling being different - we should move all the effect processing into a single place to make it deterministic.

We should also probably decide if its a feature or a bug to overlap effects.

Bubu commented 3 years ago

I've also seen that in the sender side.

vringar commented 2 years ago

I just observed that the linux desktop client wouldn't trigger any effect, when receiving messages with /confetti but would trigger the effect when a /confetti message was sent from the client. This affects both nightly and stable. Does this belong into this issue?