element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.03k stars 1.96k forks source link

Show image resolution in lightbox #17014

Open t3chguy opened 3 years ago

t3chguy commented 3 years ago

The new lightbox is lightyears ahead of the old one, thanks @niquewoodhouse & @SimonBrandner - but I miss my stats for nerds :'(

niquewoodhouse commented 3 years ago

@t3chguy this probably seems really obvious to you but would you mind just explaining why this is important/when its important to know and how important it is compared to other things on the screen.

I'm just struggling to see where it fits in the hierarchy, and not seeing it in competitor apps made me think its not actually helpful. Any insight would be really welcome, thanks :)

t3chguy commented 3 years ago

Fair point about it not being in competitors, I find it important to save me having to download it or inspecting the event to find that out, e.g if I am considering using something as a wallpaper/screensaver I'd need to know the resolution to see whether its good enough

It isn't super important, I think it could be in the subscript text with the date/time at image

e.g

$DATE $TIME - $INFO

Maybe the size could just be on the download tooltip, I don't think they need to be super accessible

image

waclaw66 commented 3 years ago

@SimonBrandner Buttons are show over those in background, it looks messy...

obrazek

SimonBrandner commented 3 years ago

@waclaw66, I've heard that this could happen but there wasn't a clear reproduction case. Could you please open a new issue and add some steps to reproduce it? I'll try to look into it

robintown commented 2 years ago

We now show the file size, but still not the resolution