element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.2k stars 2k forks source link

History setting implies history in encrypted, publicly joinable rooms will work #18615

Open ghost opened 3 years ago

ghost commented 3 years ago

Steps to reproduce

1. Create a public room with E2E encryption. 2. Ensure, that you allow users to access history messages.

settings

3. Of course, there's only two ways to add new users to that room.

What happened?

User is not able to view the past messages (conversation history).

What did you expect?

User should see the past messages (conversation history) because of settings "Who can read history?" given.

Operating system

No response

Browser information

No response

URL for webapp

No response

Have you submitted a rageshake?

No

dbkr commented 3 years ago

Although publicly joinable, encrypted rooms are a bit of a weird case, nonetheless we should probably just make this not imply that will work, somehow.

ghost commented 3 years ago

Although publicly joinable, encrypted rooms are a bit of a weird case, nonetheless we should probably just make this not imply that will work, somehow.

Not so weird if we wanna set broadcast room freely joinable only from our federation - so it's important that is encrypted E2E, but at the same time freely joinable for our users. So, it has sense, if following settings are ON: 1

svntp commented 1 year ago

I think this issue is still relevant today, especially in combination with Spaces.

If an encrypted room is part of a space and has the access setting "Space member", no history is available if a space user joins directly. If he joins via invitation, the history is shown.