search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.21k stars 2k forks source link

Ability for sender to respond to keyshare requests from new verified recipient devices #18666

Closed ara4n closed 2 years ago

ara4n commented 3 years ago

Currently, if a recipient sees a UISI they send a keyshare request to all their other devices, and the specific device which sent the message in the first place. (We don't send the request to the sender's other devices, as they don't necessarily know independently of the server whether the recipient was in the room at the point that the message was sent).

However, the specific device which receives the request currently will not service the request unless the requesting device is the one they sent the key to in the first place. So, if there's a netsplit, and a new device is added on the far side of the netsplit, that new device will request but never receive keys from the sending device. If the newly added device has been verified, then the sender should be happy to share keys with it.

novocaine commented 3 years ago

Downloading to O-Low as I believe netsplits are rare

turt2live commented 2 years ago

Duplicate of https://github.com/vector-im/element-meta/issues/1888