search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
Apache License 2.0
10.96k stars 1.94k forks source link

Permalinks behave unreliably when target hidden by pre-join-UISI-hider #19230

Open kittykat opened 2 years ago

kittykat commented 2 years ago

Steps to reproduce

  1. In a room with multiple pinned messages, open the pinned panel

  2. Room settings need to have encryption enabled:

    Screenshot from 2021-09-29 11-51-26

    Screenshot from 2021-09-29 11-43-28

  3. Pick any pinned messages apart from the top one and click on "view message" repeatedly

What happened?

What did you expect?

To go to the same message every time the link is clicked

What happened?

Sometimes it takes me to the message, sometimes to another point in the timeline. I have screenshots and can share the room for reproducing the issue, but they both contain private content so please reach out to me.

Germain and I believe the issue is with encryption rather than pinned messages or timeline. This bug is probably exposed by #19231

S-Major because I can't access the room history at all. Occasional because it requires encryption to be enabled.

URL for webapp

develop.element.io

Have you submitted a rageshake?

No

novocaine commented 2 years ago

Can we please expand on why we think the problem is with encryption?

t3chguy commented 2 years ago

Cannot reproduce on a couple of fresh rooms, have asked oob for more details

t3chguy commented 2 years ago

I think this is unrelated to pinning really and is a side-effect of https://github.com/matrix-org/matrix-react-sdk/pull/3881 hiding the backlog due to a gap in the timeline due to missing megolm sessions causing all sorts of confusion in the TimelinePanel.

One proposed solution to this is to replace https://github.com/matrix-org/matrix-react-sdk/pull/3881 with an ELS-like thing for UISIs which collapses them, though this could have an effect like https://github.com/vector-im/element-web/issues/11963 or https://github.com/vector-im/element-web/issues/11604

richvdh commented 1 year ago

related: https://github.com/vector-im/element-web/issues/22671