search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.22k stars 2k forks source link

Code block buttons lack tooltips #20856

Open robintown opened 2 years ago

robintown commented 2 years ago

Steps to reproduce

Hover over any code block, and look at the expand/copy buttons

Outcome

What did you expect?

The buttons should have tooltips and aria-labels.

What happened instead?

There is no textual indication of what the buttons do, which hurts accessibility.

Operating system

NixOS unstable

Browser information

Firefox 96.0.2

URL for webapp

develop.element.io

Application version

Element version: 0041ad7230a6-react-bb03298e6dad-js-9c242a9ce6d9 Olm version: 3.2.8

Homeserver

Synapse 1.51.0

Will you send logs?

No

t3chguy commented 2 years ago

I don't think this is a good first issue simply because of how those buttons are injected, making it rather difficult to re-use our existing tooltip'd buttons

yaya-usman commented 2 years ago

Hey @robintown , let me try work on this issue, I will link a draft PR to this soon. Commenting before someone else works on the issue😄