search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11k stars 1.95k forks source link

Hitting 'join' on a room in a space directory doesn't switch you to the room. #20867

Open ara4n opened 2 years ago

ara4n commented 2 years ago

Steps to reproduce

  1. Join a space (e.g. #fsfe:fsfe.org in this instance)
  2. Click the join button on the suggested https://matrix.to/#/#community:fsfe.org room

Outcome

What did you expect?

To join the room

What happened instead?

Instead, there's a pause, and the button then turns into a 'View' button. You then have to click the 'View' button to actually join the room you just asked to join.

c'est une WTF.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

nightly

Homeserver

matrix.org

Will you send logs?

No

t3chguy commented 2 years ago

This was done by user demand, as they were sick of having to go back and forth when joining many rooms. Especially if they just joined a room really far down the list, and wanted to join another one next to it, having to wait for pagination/scroll/filter would have been more annoying.

t3chguy commented 2 years ago

https://github.com/matrix-org/matrix-react-sdk/commit/27e16362b6eb1cdfb3a42145710293d2c3fbd680 was the change

https://github.com/vector-im/element-web/issues/17388 was the original issue, the Join->Spinner->View interaction was suggested by @niquewoodhouse in a DM

dbkr commented 2 years ago

presumably the point being that it does actually join it, but doesn't take you to the new room?