element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.2k stars 2k forks source link

New spotlight should be navigatable by page up/down keys #21256

Open weeman1337 opened 2 years ago

weeman1337 commented 2 years ago

Your use case

What would you like to do?

An a user I want to be able to navigate through the new spotlight search results by using the page up/down keys
so that I am able to reach my search results quickly.

Why would you like to do it?

How would you like to achieve it?

Page up/down keys should scroll the search result list by ? half/full pages.

Have you considered any alternatives?

Holding down the up/down arrow keys. But this is slow.

Additional context

No response

aaronraimist commented 2 years ago

Are you talking about searching the contents of a room? You should already be able to scroll with page up and down. If it doesn't work for you then we probably need information about what browser you are using.

If you mean arrow up and arrow down for individual results that would be https://github.com/vector-im/element-web/issues/16788

weeman1337 commented 2 years ago

Ah no - it is about the spotlight search. Wanted to make that clear by using a label. But I was unable to set it.

psavan1655 commented 1 year ago

I would like to work on it. First want to clear some doubts here. We are talking about the search bar, where we search for the rooms and all. Right?

Suggestion: Rather than doing Full / Half page scroll, we can do a fix number, Let's say scroll 10 search results on Page Up/Down. @weeman1337

weeman1337 commented 1 year ago

We are talking about the search bar, where we search for the rooms and all. Right?

Nope. It is the new search if you click into the search field on the top left:

image

NSV1991 commented 1 year ago

If this change is done, won't it override the current functionality implemented in https://github.com/vector-im/element-web/issues/16788 ?

t3chguy commented 1 year ago

@NSV1991 that issue is about timeline search, not spotlight search, also that is an unclosed issue, why would it be implementing functionality?

NSV1991 commented 1 year ago

@t3chguy Pardon me if my question is confusing. I am trying to understand what are we trying to achieve here. Below is my implementation locally (not committed yet). Please check the below video and guide me if I am in the right direction

Currently working in spotlight Spotlight current working scroll.webm

Updated new scroll in spotlight using keyboard NewUpdatedScroll.webm

t3chguy commented 1 year ago

@NSV1991 this is asking for the Page Up and Page Down keys to work in the spotlight, you seem to have just changed how the scrolling for up/down arrow keys works.

NSV1991 commented 1 year ago

@t3chguy Does this meet expectation? https://user-images.githubusercontent.com/37620010/230625165-5b01c20d-a716-43ba-9a0d-a6fb07cac56b.mp4

t3chguy commented 1 year ago

@NSV1991 almost, it seems to only be moving about 60% of a page rather than a page though