element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.01k stars 1.96k forks source link

DM Invite did not change the badge count & color on space sidebar #21276

Closed germain-gg closed 2 years ago

germain-gg commented 2 years ago

Steps to reproduce

  1. Disable "show all rooms" on your home space
  2. Have a space in common with the user that is going to invite you
  3. Receive an invite from said user

Outcome

What did you expect?

For the badge counter to increase by one, and for the badge color to turn red and to get binged

What happened instead?

I got binged, but because I was viewing another space that I do not share with that user, I did not see their invite until I viewed the home space

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

t3chguy commented 2 years ago

Badge counts for DMs are specifically omitted from spaces, regardless of whether they are invites or not, as you often share multiple spaces with a given party and having lots of unread badges was noisy.

t3chguy commented 2 years ago

I got binged, but because I was viewing another space that I do not share with that user, I did not see their invite until I viewed the home space

Did you not see the invite badge on Home/People either?

germain-gg commented 2 years ago

Yeah the home space showed 1 unread grey notification (from an existing room). The People space remained badge-less

turt2live commented 2 years ago

I have the same issue, but did not have a badge on the Home space. The DM invite was completely silent until I accidentally ran across it.

t3chguy commented 2 years ago

So this is currently working "as intended" because Home shows invites regardless of any preferences. Right now the rule is to only show DM notifications in the Space Panel on the Home or People metaspaces, never on the actual Spaces given that a user (and thus that DM) may be in multiple real spaces, and it can get really messy

Needs product input for how it should work across the platforms

t3chguy commented 2 years ago

Yeah the home space showed 1 unread grey notification (from an existing room). The People space remained badge-less

This sounds like a straight defect but one I cannot reproduce

image image
germain-gg commented 2 years ago

Duplicate of https://github.com/vector-im/element-web/issues/20381