element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.18k stars 2k forks source link

Can't view message edits #21321

Open HarHarLinks opened 2 years ago

HarHarLinks commented 2 years ago

Steps to reproduce

  1. click on the (edited) text after an edited message

Outcome

What did you expect?

show edit diff

What happened instead?

https://user-images.githubusercontent.com/2803622/156798430-2de722b2-aeae-4dde-8ac3-ebfbca3d8794.mp4

The message in the video is publicly accessible in the TWIM room: https://matrix.to/#/!QQpfJfZvqxbCfeDgCj:matrix.org/$5RqkiA_deYhICPh4CJ95E48kMWeHcQSMd4RcYreH-XY?via=matrix.org&via=kde.org&via=envs.net

Operating system

arch

Application version

Element Nightly version: 2022030401 Olm version: 3.2.8

How did you install the app?

aur

Homeserver

1.53

Will you send logs?

No

HarHarLinks commented 2 years ago

Something weird happens when you repro this, then open settings and try to click outside of the settings modal to close it. Noticed when I copied the app version from settings.

MTRNord commented 2 years ago

image

Error log I am seeing on develop for this

HarHarLinks commented 2 years ago

This might actually be 2 issues:

  1. element should not fail and just close the modal, but instead at least say how/why it fails
  2. the message may or may not be to spec, as the author says

    I did one edit in Fluffychat, one in Element-desktop and one in Element-android, I think. Testing, I call it. :-)


I should note that I can view the diffs of other edited messages

julianfoad commented 2 years ago

All I can add is, it gets pretty tedious to see markdown rendered differently on different platforms, and then for various editors to mangle it when round-trip editing a message. Rather than hunting down specific edge cases, which could be an endless rabbit-hole, I would prefer this class of bugs to be addressed by any moves possible toward standardising markdown across platforms, even if that means choosing a markdown flavour that is better standardized over one that includes a cool feature.

robintown commented 2 years ago

@julianfoad That would be a different issue (https://github.com/vector-im/element-meta/issues/1493 perhaps), as this one is just about the edit history dialog crashing.