"People" section of room list resizes when switching spaces

jaywink commented 2 years ago

Steps to reproduce

Pre-requirements / current state:

Have a space with the "People" section of the room list turned on (Space preferences, "People" checked)
Have the "People" metaspace enabled in sidebar settings
Have enough dm's crossing enough time for the bug to happen
Rooms/people ordered by "activity" (and "unread first", though expecting that not to matter here)

How to reproduce:

Adjust the space with the "People" section to "show less" and then resize to something like one person visible
Switch to the "People" metaspace
Scroll down to an old dm where the last message is older than the last messages in the top rooms in the space with the People section
Open that dm and write a message to it
Switch back to the space with the "People" section

Outcome

What did you expect?

The space with the "People" section is still sized as I sized it before, ie it shows one person in this case.

What happened instead?

The "People" section is resized to contain enough items to accommodate for a lot more people than what I resized it for. I can't see a correlation how much more it gets resized to, possibly the amount of rooms that I scrolled down in the "People" metaspace?

While this is reported on nightly, this bug has existed from somewhere late 2021. Couldn't find a similar matching bug and unfortunately wasn't sure what behaviour to report before.

Operating system

Ubuntu

Application version

Element Nightly version: 2022031001 Olm version: 3.2.8

How did you install the app?

Official nightly repos

Homeserver

https://federator.dev

Will you send logs?

Yes

t3chguy commented 2 years ago

Its part of the accessibility feature set, it makes sure the selected room is visible in the room list, the issue is depending on your room list settings the act of navigating to that room may immediately move it to the top, not related to switching spaces, can happen when searching/jumping via link too.

jaywink commented 2 years ago

In this case however (sorry forgot to mention), the person I chat to to reproduce this isn't a member of the space where I have my People section active. So there shouldn't be a reason for the room list on the space without the room that got new messages to be readjusted, as the room wouldn't show anyway?

Pattygeek commented 2 years ago

@gsouquet Hi, I am an outreachy applicant, please can you assign this issue to me?

SimonBrandner commented 2 years ago

@gsouquet Hi, I am an outreachy applicant, please can you assign this issue to me?

I've assigned you to the issue. If you need any help/have any questions be sure to visit #element-dev:matrix.org!

element-hq / element-web