search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.14k stars 1.98k forks source link

Design of secret key dialogs inconsistent #21572

Open luixxiul opened 2 years ago

luixxiul commented 2 years ago

Steps to reproduce

  1. Open a private tab on a browser
  2. Log in

Outcome

What did you expect?

The style of the dialogs should be consistent.

after2

after1

after

What happened instead?

Values of border-radius, color, padding, etc. are decided without a specific policy.

Operating system

No response

Application version

develop branch

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

yaya-usman commented 2 years ago

@luixxiul can you assign me this issue?

yaya-usman commented 2 years ago

@luixxiul can you assign me this issue?

Figured out there is a pull request already

luixxiul commented 2 years ago

FYI I cannot assign anyone as I am not a team member.

goelesha commented 2 years ago

@luixxiul I would like to work on the issue if it's still open.

SimonBrandner commented 2 years ago

@luixxiul I would like to work on the issue if it's still open.

https://github.com/matrix-org/matrix-react-sdk/pull/8167 already fixes the issue

DevanshRaizada commented 2 years ago

I would like to work on the issue if its still open?

SimonBrandner commented 2 years ago

I would like to work on the issue if its still open?

https://github.com/matrix-org/matrix-react-sdk/pull/8167 already fixes the issue

luixxiul commented 1 year ago

I will not work on this issue.