search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.12k stars 1.98k forks source link

MLocationBody 'Expand map' z-index stacks over message composer #21619

Open kerryarchibald opened 2 years ago

kerryarchibald commented 2 years ago

Steps to reproduce

  1. Share a location, then post a few normal messages below so you can scroll the chat timeline down
  2. Scroll the chat timeline so the map and the message composer overlap
  3. Hover on the map, notice the 'expand map' stacks over the message composer

https://user-images.githubusercontent.com/3055605/161209500-b89fae68-3a60-4bb6-afab-412a7970b9f9.mov

Outcome

What did you expect?

What happened instead?

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

goelesha commented 2 years ago

@kerryarchibald Can you pls elaborate more on the issue. I tried reproducing the issue but the expand map z index stacks within the map for me, as shown below.

Screenshot 2022-03-31 at 11 08 45 PM
kerryarchibald commented 2 years ago

Hi @goelesha, I've updated the description to be more clear, hope that helps!

goelesha commented 2 years ago

Hi @goelesha, I've updated the description to be more clear, hope that helps!

Hi, @kerryarchibald Yeah I am able to reproduce the issue on the hosted version of the app. But on localhost, I see this error "Unable to load map: This homeserver is not configured to display maps."

I would like to work on this issue. Can you help me with how can I reproduce the issue on localhost.

kerryarchibald commented 2 years ago

@goelesha Ah yes, you need to configure the map_style_url in your element-web config.json, check the docs for it here: https://github.com/vector-im/element-web/blob/develop/docs/config.md I use the same one as suggested in the docs https://api.maptiler.com, you'll need to sign up to get an api key.

If you have any more questions or sticky points please reach out in https://matrix.to/#/#element-dev:matrix.org

goelesha commented 2 years ago

@goelesha Ah yes, you need to configure the map_style_url in your element-web config.json, check the docs for it here: https://github.com/vector-im/element-web/blob/develop/docs/config.md I use the same one as suggested in the docs https://api.maptiler.com, you'll need to sign up to get an api key.

If you have any more questions or sticky points please reach out in https://matrix.to/#/#element-dev:matrix.org

Noted @kerryarchibald Kindly assign this issue to me. I would like to work on it. Thanks!

goelesha commented 2 years ago

@kerryarchibald can you pls guide me.

I am confused about how to edit the properties of tooltip. In MBodyLocation.tsx the tooltip is displayed using TooltipTarget. If I change the properties of Tooltiptarget then it would change all the tooltips. I want to seek help on what would be a nice approach to handle the issue.

I posted the same msg on public chat also but didn't receive any response.

andybalaam commented 2 years ago

@goelesha is still actively working on https://github.com/matrix-org/matrix-react-sdk/pull/8343 and questions and answers are being exchanged there.

kittykat commented 1 year ago

@goelesha I'm going to unassign this issue from you as we haven't seen any activity in a while. Please feel welcome to continue working on it :+1: