We still show the "add phone number" UX in user settings even if no identity server is in use - Githubissues

element-hq / element-web

A glossy Matrix collaboration client for the web.

https://element.io

GNU Affero General Public License v3.0

11.18k stars 2k forks source link

We still show the "add phone number" UX in user settings even if no identity server is in use #21708

Open lampholder opened 2 years ago

lampholder commented 2 years ago

Steps to reproduce

Disable your connection to the identity server
Try and add a phone number
Observe: a 500 error (after you've been told that the SMS has been sent)

Outcome

What did you expect?

The add phone number UX should be suppressed when there is no identity server.
Really, the "SMS has been sent" confirmation should be conditional on a 200 from the identity server send SMS request, not just included as part of the local echo.

What happened instead?

500

Operating system

All of them

Browser information

Firefox Nightly

URL for webapp

app.element.io

Application version

Latest

Homeserver

matrix.org

Will you send logs?

No

t3chguy commented 2 years ago

Related https://github.com/vector-im/element-meta/issues/766