element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.23k stars 2k forks source link

Refresh the DM dialog interface #22065

Open daniellekirkwood opened 2 years ago

daniellekirkwood commented 2 years ago

Your use case

Screenshot 2022-05-04 at 15 13 03

Have you considered any alternatives?

No response

Additional context

No response

t3chguy commented 2 years ago

Isn't this dialog going away with Spotlight?

daniellekirkwood commented 2 years ago

It is? What's the new design?

@niquewoodhouse & @kittykat

niquewoodhouse commented 2 years ago

I don't think it is but maybe I've assumed something incorrectly @kittykat @gsouquet?

t3chguy commented 2 years ago

Isn't spotlight going to feature ways to search for public rooms & users? If it is why maintain an entirely different dialog also to search for users?

germain-gg commented 2 years ago

Yes it is. I believe the idea is to consolidate the "start DM", public room directory and local filtering under the same umbrella

It does not need to be transitioned immediately when we move spotlight out of beta, but that's the ultimate goal I suppose. @niquewoodhouse let me know if you think that would change some of the design decisions we've made in that area

niquewoodhouse commented 2 years ago

let me know if you think that would change some of the design decisions we've made in that area

I understand if that's the ultimate goal maybe but, in the immediate future, it can't replace start DM as it doesn't have functionality, like:

Search is looking for someone, but starting a DM might be wanting to share a link, inviting via email etc

image
kittykat commented 2 years ago

@niquewoodhouse if we implement the new dialog, there won't be a way to get to this one easily so we should add the old functionality to the new dialog

kittykat commented 2 years ago

Update: after discussion, we decided to link to this dialog from the new search experience when people want to create new group chats. (Germain will file additional issues around new user experiences with creating group chats.)

daniellekirkwood commented 2 years ago

In that case I'm assigning this to @gsouquet :)

I will ask y'all to run me thru this next week but from what I can gather it sounds like it would fit right in to new user journey work so @gsouquet please tag the new issues with Z-NewUserJourney

germain-gg commented 2 years ago

I believe keeping this issue as the main reference will fit the bill both for the the new users journey, and also to help getting the new search experience out of beta (as this create DM dialog, will be the main entry point to create multi-party DMs)

@niquewoodhouse would you be able to share some a redesign of this direct message modal, you've shared some early thoughts, but it'd be good to have something a bit more formalised

After scanning the code a bit more, here are some things we need to consider:

Assigning @justjanne to this one so that she can look after this whilst I'm away after we have the design from Nique

daniellekirkwood commented 2 years ago

While we're morphing this issue into the Search solution (and then using the same modal in both places) can we check with the folks looking at the Start a DM flow to make sure we're not missing anything they might know about? (I think they're focussing on mobile only but not sure). @niquewoodhouse the Figma I have from G is here: https://www.figma.com/file/OvsSONqAyabcUDYp8tnEs6/Start-a-DM?node-id=68%3A31998

daniellekirkwood commented 2 years ago

Current state as discussed in out meeting yesterday:

Is this issue needed in order to bring search out of Beta?

I believe the answer to be no, WDYT @kittykat

If the answer is no, then we'll push this back to the Delight backlog and work on other things first.

kittykat commented 2 years ago

@daniellekirkwood this isn't needed to bring search out of beta. The epic for exit out of beta is up to date 👍

daniellekirkwood commented 2 years ago

Great, removing Janne from the Assignees and moving to the Next column as we'll pick this back up after Search & Welcome home work