element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.21k stars 2k forks source link

Improve map error view #22588

Open weeman1337 opened 2 years ago

weeman1337 commented 2 years ago

Your use case

What would you like to do?

As a user I don't want to be scared away by a map error.

This is how it looks at the moment:

image

Why would you like to do it?

Improve the UI. Let it look nicer.

How would you like to achieve it?

We already have a placeholder for expired live shares:

image

Have you considered any alternatives?

No response

Additional context

No response

kerryarchibald commented 2 years ago

Discussed with Gaelle, static location shares should use the same 'map server unavailable error' UI as live location shares Reusable component here: https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/components/views/location/MapError.tsx

Screenshot 2022-07-20 at 11 37 25

https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=2302%3A64561

weeman1337 commented 2 years ago

In my opinion „home server“ is alien speech :space_invader:

What about changing it to

„Unable to load map :information_source:“

Where :information_source: can have a tooltip with the content „This home server is not configured to display maps. Contact your friendly admin.“. That hides :space_invader:-speech and gives the user a hint on what to do now.

gaelledel commented 2 years ago

Yes to add "Contact your admin for more help" After "This home server is not configured to display maps."

t3chguy commented 2 years ago

I think homeserver should be one word not two