element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.04k stars 1.96k forks source link

"Something went wrong!" when viewing an invite created by a facebook bridge. #22710

Open anton-molyboha opened 2 years ago

anton-molyboha commented 2 years ago

Steps to reproduce

  1. A facebook friend starts a new conversation with me in Facebook Messenger.
  2. Facebook bridge creates a new matrix room and invites me to join it.
  3. I see "Empty room" among the "Invites" in the Element UI.
  4. I click on the "Empty room"

The bridge is mautrix-facebook version 0.3.3, https://github.com/mautrix/facebook

Outcome

What did you expect?

I expect an option to accept the invite.

What happened instead?

I see "Something went wrong!" screen.

Operating system

Windows

Application version

Element version: 1.10.15 Olm version: 3.2.8

How did you install the app?

No response

Homeserver

Dendrite 0.8.7 compiled locally, running in "monolith" mode.

Will you send logs?

Yes

anton-molyboha commented 2 years ago

Somewhere in Settings I found an "Accept all invites" button. Using this button, the invite is accepted and I can see the new room.

dbkr commented 2 years ago

The debug logs have caught the problem here - element is crashing because mautrix-facebook hasn't included some info in the invite. Element should probably not crash in this scenario.

tulir commented 2 years ago

@dbkr What info? Clients/bridges only have control over the content of the invite event, which is basically just the invitee's profile (displayname and avatar_url) and the is_direct flag. Everything else (like invite_room_state in unsigned) is the homeserver's responsibility.

sebastian-de commented 1 year ago

I face the same issue with mautrix-signal. I can accept the invite when using nheko without problems, but not with element-web. So it seems that this is indeed a problem with element and not with the bridge.