element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.14k stars 1.99k forks source link

Ended Live Location leads to endless loading / freezes element #22905

Open Tupsi opened 2 years ago

Tupsi commented 2 years ago

Steps to reproduce

  1. Have a room with people with a history of messages
  2. Start a "live location share" with your android smartphone
  3. Stop the sharing, so that on the android smartphone it states "Live location ended"
  4. Visit the room in element browser or element windows desktop

Outcome

What did you expect?

Seeing the same info item like on the smartphone stating "Live location ended". Still be able to scroll up and down the message history of the room.

What happened instead?

Endless "loading animation", cpu usage moves to high in windows task manager, program is unresponsive. History of chat is not shown, only newer messages then the one where the "Live location" was.

Operating system

Windows

Application version

Version von Element: 1.11.0 Version von Olm: 3.2.8

How did you install the app?

element.io

Homeserver

Snapse 1.62.0

Will you send logs?

Yes

Tupsi commented 2 years ago

as a workaround it would be awesome if one could delete the problematic post (with the ended live location). I tried that, but a right click with a proper menu (and "delete" in it) is not available, even on the android side, where you have no issues.

Tupsi commented 2 years ago

I found a hotfix (at least for me) to make my room usable again. I upgraded the room with /upgraderoom 9 which of course just creates a new room, but at least I can use it again. For reference the old room version was 6. I also tested it on a brand new room which just version 9 and did not have any issues with the feature as described above. Maybe that helps you guy a bit finding the problem (like room v6 is to old for this feature in the first place).

manning-ncsa commented 1 year ago

Thanks for sharing your workaround @Tupsi . This has been affecting me as well. Perhaps this is not a bug per se, but it would make sense for Element to warn you when sharing location that the room version is too old. My app and room versions for reference:

Element version: 1.11.13 Olm version: 3.2.12 Room version: 1

Tupsi commented 1 year ago

but it would make sense for Element to warn you when sharing location that the room version is too old.

👍 def. that. You just run into that problem otherwise and have no clue how to get out of it. But I guess this is just a problem which goes away over time by itself when every room on every matrix instance has been upgraded for some reason or another. :-)

As a general rule of thumb I think that a feature should not even be visible if it can not be used inside the current room the user is in.

torrybr commented 1 year ago

This is happening to me but during location shares in rooms with ~10 people and during active shares in v9 rooms