search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.22k stars 2k forks source link

Thread deleted message pops up for a very short time on load #23003

Open weeman1337 opened 2 years ago

weeman1337 commented 2 years ago

Steps to reproduce

  1. Start a thread
  2. Delete the thread and the message
  3. Reload

Outcome

What did you expect?

Not seeing my deleted message

What happened instead?

Deleted message pops up for a short time period („Hi“ message in video)

hi

Operating system

Ubuntu 22.04 LTS

Browser information

Firefox 103.0.1

URL for webapp

https://develop.element.io/

Application version

Version von Element: 3e3f279469ad-react-e864dbfacf01-js-3907d1c28f87 Version von Olm: 3.2.12

Homeserver

No response

Will you send logs?

No

turt2live commented 2 years ago

I don't think this is a bug we'll be able to fix. The sync accumulator didn't have a chance to persist the redaction, so it's still using the original event.

MadLittleMods commented 2 years ago

We can fix the sync accumulator persist better instead of every 5 minutes. Currently, this would be hard because it's one big giant JSON that takes a while to persist but we can refactor how we store things to be more managable.

This kind of edge case also causes the "Beware: edge case" explained in https://github.com/matrix-org/matrix-react-sdk/pull/8354 where the history refresh can appear multiple times.