search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.27k stars 2.01k forks source link

Investigate timeline scrolling issues #23539

Open turt2live opened 2 years ago

turt2live commented 2 years ago

There are a number of issues around scrolling in the timeline that, individually and together, can make for a quite poor experience in certain cases:

Before engaging in a larger rewrite of the timeline code, we'll need data points on whether or not it's possible to fix these issues with reasonable time investments. Therefore, the idea is to attempt fixes on two of the existing issues under this epic and use the outcome to drive further decision making.

Time sheeting

Project: Web: Scrolling

daniellekirkwood commented 1 year ago

Also look into the Jump-to-date feature

claell commented 1 year ago

@Johennes Can you give a short update on the course change you mentioned in https://github.com/vector-im/element-web/issues/23540#issuecomment-1420953646? Seems like before it was planned to fix the issues, and now it's an investigation first. What happens if it turns out the issues can't be fixed with reasonable time effort? Leave them as they are?

Johennes commented 1 year ago

vector-im/element-web#23540 meant to prepare a full rewrite of the timeline to fix the various issues in this epic. After reconsidering, we concluded that this isn't a good next step. For one thing, replacing the timeline code requires a mighty investment of effort. For another, most of the issues listed here didn't exist at some point which hints at the possibility to fix the current implementation without a rewrite. The course change is to investigate that latter option. We'll reconsider the subsequent once this is completed – whether successfully or not.

claell commented 1 year ago

Sounds good. Though also the description of this issue has been changed from fixing to investigating (and estimating the effort). But in general seems to make sense. As a user, I just hope, this can see some priority, so that https://github.com/matrix-org/matrix-react-sdk/pull/9340 can get merged which might also fix some other stuff as mentioned in https://github.com/matrix-org/matrix-react-sdk/pull/9340#issuecomment-1266128320. As always, I am available for testing and reproducing, also via video call for example.

Johennes commented 1 year ago

Sounds good. Though also the description of this issue has been changed from fixing to investigating

Yes, we split the two so that we can schedule them separately in the roadmap. So the idea would be to have another epic for the actions that come out of this one.

I just hope, this can see some priority, so that https://github.com/matrix-org/matrix-react-sdk/pull/9340 can get merged

Yes, https://github.com/matrix-org/matrix-react-sdk/pull/9340 claims to fix https://github.com/vector-im/element-web/issues/23393 which is one of the two tasks under investigation in this epic. So I would expect us to revisit that PR as part of this project. I've added it into the checkbox in the issue description to make this more clear.

andybalaam commented 1 year ago

Comment from @MadLittleMods about potentially-related issues. Dropping here in case we want to include them when we work on this:

In addition to timeline scroll problems, there is a timeline reliability problem: