element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11k stars 1.95k forks source link

Live location share doesn't show description #24517

Open ara4n opened 1 year ago

ara4n commented 1 year ago

Steps to reproduce

If a LLS beacon includes a description, we should show it on the map entry in the timeline (just like we show it on hoverover when viewing the map, or in the 'view list' view on the map).

Outcome

What did you expect?

My LLS maps to have descriptions in the timeline

What happened instead?

No descriptions

Operating system

No response

Browser information

No response

URL for webapp

develop.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No

MadLittleMods commented 1 year ago

@ara4n I'm trying to triage this issue and trying to gather more context behind how important this information is.

I have no context what a live location sharing beacon looks like. What would an example of a description be? Can you share an screenshot of how it looks on hoverover where it is shown?

t3chguy commented 1 year ago

Closing due to lack of requested info

MadLittleMods commented 1 year ago

Tried out live location sharing and I still don't know exactly what a description is or where it is displayed in the UI. The .mx_BeaconStatus_description in the UI, just shows my display name.

In the org.matrix.msc3672.beacon events, I don't see a description. In org.matrix.msc3672.beacon_info, I do see a description ("madlittlemods (Eric Eastwood)'s live location") but it doesn't seem helpful at least what Element Web generated and doesn't match anything in the UI as far as I can tell. Are there more/better useful examples here?

org.matrix.msc3672.beacon ```json { "type": "org.matrix.msc3672.beacon", "content": { "org.matrix.msc3488.location": { "uri": "geo:51.507351,-0.127758;u=150" }, "org.matrix.msc3488.ts": 1678987016908, "m.relates_to": { "rel_type": "m.reference", "event_id": "$QXYKqW1rsdTv5G2O1HC6ahzjrBnzdmzgrbsNblIycK0" } } } ```
org.matrix.msc3672.beacon_info ```json { "content": { "description": "madlittlemods (Eric Eastwood)'s live location", "live": false, "org.matrix.msc3488.asset": { "type": "m.self" }, "org.matrix.msc3488.ts": 1678986955775, "timeout": 900000 }, "origin_server_ts": 1678987159451, "sender": "@madlittlemods:matrix.org", "state_key": "@madlittlemods:matrix.org", "type": "org.matrix.msc3672.beacon_info", "unsigned": { "replaces_state": "$QXYKqW1rsdTv5G2O1HC6ahzjrBnzdmzgrbsNblIycK0", "prev_content": { "description": "madlittlemods (Eric Eastwood)'s live location", "live": true, "org.matrix.msc3488.asset": { "type": "m.self" }, "org.matrix.msc3488.ts": 1678986955775, "timeout": 900000 }, "prev_sender": "@madlittlemods:matrix.org", "age": 155 }, "event_id": "$xxx", "room_id": "!xxx" } ```

For anyone wanting to share screenshots and sensitive about their location, you can spoof your location in Chrome devtools by pressing escape to open the extra pane at the bottom -> Sensors -> Location

ara4n commented 1 year ago

In Eric's example above, the description is:

{
  "content": {
    "description": "madlittlemods (Eric Eastwood)'s live location",

i.e. the description key of the content object. I'd expect it to be shown in the timeline somehow...

image

...but it isn't. Which is a pain, as if you have many beacons in a room, you can't see which is which, or what they even are, e.g:

Screenshot 2023-04-20 at 18 19 01
gaelledel commented 6 months ago

@daniellekirkwood More likely a product consideration if we want to support this use case or not.

daniellekirkwood commented 6 months ago

I think Matthew is accurate - that it would be nice to have "Eric's location" instead of "Live location" so that if there are several in a room you can tell the difference.

For right now, I think this is low priority though so wouldn't spend time on it.