Open DalekDave opened 1 year ago
Looks like the login screen is currently fixed to use the light theme in https://github.com/matrix-org/matrix-react-sdk/blob/johannes/newline-pills/src/settings/watchers/ThemeWatcher.ts#L102 and https://github.com/matrix-org/matrix-react-sdk/blob/johannes/newline-pills/src/settings/controllers/ThemeController.ts#L33.
It doesn't look overly attractive after commenting these lines though and will likely require some design input.
Hi thanks for your comments. Indeed, this should be reviewed as part of a full design sprint for the sign in flow using compound.
Steps to reproduce
Server OS: Ubuntu 20.04 Web server: Nginx 1.18 Desktop operating system: Kubuntu 22.04 Web browser: Firefox (latest current version)
I installed Element 1.11.23 on my server and set the default theme to Dark in my config.json (please see attached screenshot) below.
I browsed to to my Element instance at https://matrix.t25b.com.
Outcome
What did you expect?
I expected to see the Element welcome page dark-themed.
What happened instead?
Instead, the Element welcome page was light-themed.
Blinded and dazzled, I fell off my chair.
This is actually a long-standing bug.
For me, the 'default_theme' setting in config.json is meant to apply to the welcome pages of Element, not just the theming of Element once I've logged in.
I want it dark, please. Preferably covered in hot melted chocolate, but at least DARK!
I want darkness from the moment I hit the login / registration / password reset pages.
Please could we finally fix this in the next release?
And thank you so much for your work on Element. 1.11.23 is another great release.
Operating system
Ubuntu 20.04 Server Edition
Browser information
Firefox on Kubuntu 22.04
URL for webapp
https://matrix.t25b.com
Application version
Element 1.11.23
Homeserver
matrix.org
Will you send logs?
Yes