search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.23k stars 2k forks source link

Failing Percy tests due to roving tab index race #24689

Closed andybalaam closed 7 months ago

andybalaam commented 1 year ago

Steps to reproduce

Some Percy tests are failing due to what appears to be a different tab position. Examples:

t3chguy commented 1 year ago

This is more likely unrelated to mouseover and not a flake; most likely to be a legitimate bug/race in the roving tab index.

andybalaam commented 1 year ago

Example: https://percy.io/dfde73bd/matrix-react-sdk/builds/25531269/changed/1423277393?browser=edge&browser_ids=18%2C33%2C34%2C35&subcategories=unreviewed%2Cchanges_requested&viewLayout=overlay&viewMode=new&width=1920&widths=1024%2C1920

t3chguy commented 7 months ago

Percy tests are gone