All of them seem to have taken snapshots of the right panel without their content. They are supposed to take snapshots ThreadView including EventTiles and a poll.
Outcome
What did you expect?
They should take snapshots of contents inside ThreadView.
What happened instead?
They take snapshots of the ThreadView without its content such as EventTiles, redacted messages placeholder, etc. on modern layout and bubble layout (note that there is not IRC layout on ThreadView).
t3chguy
commented
7 months ago
Steps to reproduce
The PR https://github.com/matrix-org/matrix-react-sdk/pull/9016 has added Percy tests to detect visual regressions of
EventTiles insideThreadView.Initial ThreadView on group layoutandInitial ThreadView on bubble layouthttps://github.com/matrix-org/matrix-react-sdk/commit/f60f7a19af8257d94132bdb413c0416c7b27e333#diff-44347e35ab8f425bcd830646976351b243602f12674e9e306060b0a17697c65bR112-R116 -ThreadView with reaction and a hidden event on group layouthttps://github.com/matrix-org/matrix-react-sdk/commit/f60f7a19af8257d94132bdb413c0416c7b27e333#diff-44347e35ab8f425bcd830646976351b243602f12674e9e306060b0a17697c65bR194-R196ThreadView with reaction and a hidden event on bubble layouthttps://github.com/matrix-org/matrix-react-sdk/commit/f60f7a19af8257d94132bdb413c0416c7b27e333#diff-44347e35ab8f425bcd830646976351b243602f12674e9e306060b0a17697c65bR216-R218ThreadView with redacted messages on group layoutandThreadView with redacted messages on bubble layouthttps://github.com/matrix-org/matrix-react-sdk/commit/f60f7a19af8257d94132bdb413c0416c7b27e333#diff-44347e35ab8f425bcd830646976351b243602f12674e9e306060b0a17697c65bR246-R252Reply to the location on ThreadViewhttps://github.com/matrix-org/matrix-react-sdk/commit/f60f7a19af8257d94132bdb413c0416c7b27e333#diff-44347e35ab8f425bcd830646976351b243602f12674e9e306060b0a17697c65bR463It turns out they do not really work how they are supposed to.
ThreadView with reaction and a hidden event on bubble layoutReply to the location on ThreadViewThreadView with redacted messages on group layoutThreadView with redacted messages on bubble layoutThreadView with reaction and a hidden event on group layoutInitial ThreadView on bubble layoutInitial ThreadView on group layoutAll of them seem to have taken snapshots of the right panel without their content. They are supposed to take snapshots
ThreadViewincludingEventTiles and a poll.Outcome
What did you expect?
They should take snapshots of contents inside
ThreadView.What happened instead?
They take snapshots of the
ThreadViewwithout its content such asEventTiles, redacted messages placeholder, etc. on modern layout and bubble layout (note that there is not IRC layout onThreadView).Operating system
No response
Browser information
No response
URL for webapp
No response
Application version
develop branch
Homeserver
No response
Will you send logs?
No