element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.23k stars 2k forks source link

Getting notifications for display name changes due to enabling simplified notification settings #26097

Closed hanthor closed 1 year ago

hanthor commented 1 year ago

Steps to reproduce

Just today I've started seeing macOS notifications for join/leave events and display name changes

It might be since I clicked the button to enable the simplified notification settings

Outcome

What did you expect?

Not get those notifications? Especially since I have them hidden on the timeline

What happened instead?

Operating system

macOS

Application version

Element version: 1.11.40 Olm version: 3.2.14

How did you install the app?

Homebrew

Homeserver

element.io

Will you send logs?

Yes

hanthor commented 1 year ago

These two settings were turned on when clicking the simplifies notifications button

image

t3chguy commented 1 year ago

@hanthor so tweaking the settings to your liking fixed the issue for you?

hanthor commented 1 year ago

Yeah, so the "bug" is that the migration turned these on when they were off before?

On Mon, Sep 4, 2023, 4:03 AM Michael Telatynski @.***> wrote:

@hanthor https://github.com/hanthor so tweaking the settings to your liking fixed the issue for you?

— Reply to this email directly, view it on GitHub https://github.com/vector-im/element-web/issues/26097#issuecomment-1704799055, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMR4OPFD2D4TBTAIUSXJ7TXYWDL3ANCNFSM6AAAAAA4H5CTPQ . You are receiving this because you were mentioned.Message ID: @.***>

--

Copyright © 2023 Element - All rights reserved. The Element name, logo and device are registered trademarks of Element Software Inc. Registered number: 3655605. Registered in the State of Delaware. Registered address: 1209 Orange Street, City of Wilmington, County of Newcastle, Delaware 19801, United States.

This message is intended for the addressee only and may contain private and confidential information or material which may be privileged. If this message has come to you in error please delete it immediately and do not copy it or show it to any other person.

t3chguy commented 1 year ago

@hanthor I don't think we should be calling product decisions for new defaults bugs :D

cc @daniellekirkwood

hanthor commented 1 year ago

When someone change their display name I got a notification for every single room I was in with them so I got about 50 notifications... That seems buggy to me and I think would to most end users. Especially since it wasn't doing it before the migration.

On Mon, Sep 4, 2023, 8:52 AM Michael Telatynski @.***> wrote:

@hanthor https://github.com/hanthor I don't think we should be calling product decisions for new defaults bugs :D

cc @daniellekirkwood https://github.com/daniellekirkwood

— Reply to this email directly, view it on GitHub https://github.com/vector-im/element-web/issues/26097#issuecomment-1705221793, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMR4OK3UKB5WJRA5L4GPRTXYXFH5ANCNFSM6AAAAAA4H5CTPQ . You are receiving this because you were mentioned.Message ID: @.***>

--

Copyright © 2023 Element - All rights reserved. The Element name, logo and device are registered trademarks of Element Software Inc. Registered number: 3655605. Registered in the State of Delaware. Registered address: 1209 Orange Street, City of Wilmington, County of Newcastle, Delaware 19801, United States.

This message is intended for the addressee only and may contain private and confidential information or material which may be privileged. If this message has come to you in error please delete it immediately and do not copy it or show it to any other person.

t3chguy commented 1 year ago

https://github.com/matrix-org/matrix-react-sdk/pull/11247 splits membership updates from other room activity and updates that default I believe

austinbutler commented 1 year ago

Seems like a duplicate of https://github.com/vector-im/element-web/issues/25911.

t3chguy commented 1 year ago

Duplicate of https://github.com/vector-im/element-web/issues/25911