element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.17k stars 1.99k forks source link

Can't `/converttoroom` #26102

Open HarHarLinks opened 1 year ago

HarHarLinks commented 1 year ago

Steps to reproduce

  1. Create a room
  2. Send /converttodm in composer
  3. Room should now be in „People” section
  4. Send /converttoroom in composer

Outcome

What did you expect?

DM -> room

What happened instead?

DM stays DM, nothing happens

After reloading the app, the room shows up in the „Rooms“ list, sometimes (see comment).

I looked at my m.direct and found a strange address under the MXID of the other user: "!local.<some-uuid>

Operating system

w10

Application version

Element version: 1.11.40 Olm version: 3.2.14

How did you install the app?

No response

Homeserver

synapse 1.89 and 1.90

Will you send logs?

Yes

weeman1337 commented 1 year ago

Thank you for reporting the issue @HarHarLinks . I've updated the description to not let people search in the wrong place. It doesn't seem to depend on DMs. I can reproduce with normal rooms.

I looked at my m.direct and found a strange address under the MXID of the other user: "!local.<some-uuid>

These are the local „pre DM“ rooms before sending a message. I think it is unrelated to this issue.

t3chguy commented 1 year ago

@weeman1337 I don't think that's the case

image

Those lack a ! and don't feature a . after local

weeman1337 commented 1 year ago

Next update: The room is in the expected place after reload.

weeman1337 commented 1 year ago

@weeman1337 I don't think that's the case

image

Those lack a ! and don't feature a . after local

Looks like the m.direct item comes from the Android app:

@HarHarLinks can you open an issue in the Android tracker about it?

HarHarLinks commented 1 year ago

@weeman1337

Next update: The room is in the expected place after reload.

After reloading the app, the room shows up in the „Rooms“ list.

I have not re-checked with an updated version yet, but at the time I specifically tried that to avoid caching issues etc and it did not work this way for me.


@HarHarLinks can you open an issue in the Android tracker about it?

I've stopped reporting legacy-android bugs, but will do so if you think it's worth doing. It might also be related to android creating a new DM with that user thrice(!) after (unsuccessfully) converting the DM to a room.

weeman1337 commented 1 year ago

@weeman1337

Next update: The room is in the expected place after reload.

After reloading the app, the room shows up in the „Rooms“ list.

I have not re-checked with an updated version yet, but at the time I specifically tried that to avoid caching issues etc and it did not work this way for me.

@HarHarLinks can you open an issue in the Android tracker about it?

I've stopped reporting legacy-android bugs, but will do so if you think it's worth doing. It might also be related to android creating a new DM with that user thrice(!) after (unsuccessfully) converting the DM to a room.

Can you check your m.direct after /converttoroom?

HarHarLinks commented 1 year ago

using Element Nightly version: 2023090601 Olm version: 3.2.14

  1. I go to the "DM" I want to convert and note the room ID
  2. I check m.direct using devtools -> account data: the room ID is listed under the MXID that originally created the DM
  3. I do /converttoroom
  4. I check m.direct again: the room ID is now gone completely
  5. The room is still sorted under DMs
  6. I restart Element
  7. I check m.direct again: the room ID is now back where it was in step 2