search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.23k stars 2k forks source link

Emoji are small again #26401

Closed robintown closed 1 year ago

robintown commented 1 year ago

Steps to reproduce

  1. Look at a message with emoji, either in the composer or the timeline

Outcome

What did you expect?

Emoji should have a larger font size than the surrounding text

What happened instead?

Emoji are given the same font size as the surrounding text

Operating system

NixOS unstable

Browser information

Firefox 118.0.1

URL for webapp

develop.element.io

Application version

Element version: f1a39b3e4d37-react-eb7ce666b748-js-4bcea2cead97 Olm version: 3.2.14

Homeserver

Not relevant

Will you send logs?

No

t3chguy commented 1 year ago

Regressed by https://github.com/matrix-org/matrix-react-sdk/pull/11757

HarHarLinks commented 1 year ago

Emoji should have a larger font size than the surrounding text

Does this rule also apply to the topic in the new room header? If so, https://github.com/matrix-org/matrix-react-sdk/pull/11757 can be reverted entirely and another solution that instead adjusts new room header layout is required.

Johennes commented 1 year ago

Adding this to the A11y/Compound board view. @kerryarchibald maybe you could give this a look on the back of the PR mentioned above? It might also be good to verify whether we have Percy tests to cover this.

kerryarchibald commented 1 year ago

Reverting https://github.com/matrix-org/matrix-react-sdk/pull/11774 and reopening https://github.com/vector-im/element-web/issues/26326

Should have tested more carefully, I thought inline emojis being the same size as the text looked correct. Percy tests would have caught this.