element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.06k stars 1.97k forks source link

UX : "Notifications" onboarding task should be named "Desktop notifications" #26549

Closed estellecomment closed 2 months ago

estellecomment commented 11 months ago

Steps to reproduce

Edit 2024-07-04 : added screenshots

  1. Where are you starting? What can you see? Create account. The "Notifications" task is not complete (as expected).

    Screenshot 2024-07-04 at 10 47 33 AM
  2. What do you click? Go to user settings > notifications, enable notifications

    Screenshot 2024-07-04 at 10 48 15 AM

Outcome

What did you expect?

Notifications onboarding task is marked complete.

What happened instead?

Even after a refresh, it is still not marked complete.

Why is this happening ?

Because the word "Notifications" is used both for app notifications and for desktop notifications. What this task checks for is whether the browser has permission to display desktop notifications. It's confusing.

How to fix it ?

Rename the onboarding task "Desktop notifications" instead of "Notifications".

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

Aziz-4980 commented 11 months ago

hi @estellecomment can you please assign this to me? I've understood the assignment.

t3chguy commented 11 months ago

@Aziz-4980 - @estellecomment is a member of the community like yourself, they cannot assign issues nor make decisions on behalf of the product.

gaelledel commented 3 months ago

@estellecomment Hi Estelle, could you please provide more information and attach screenshot here? I don't fully understand what you mean by "notification task" Thanks

estellecomment commented 3 months ago

@gaelledel I added screenshots.

gaelledel commented 3 months ago

I see thank you. I'm not convinced we need to make a task checklist for this purpose at all. @amshakal do you have information on this? Can the step on "notifications" be removed? I am missing context for the reasoning.

amshakal commented 2 months ago

I think it's quite standard to ask people to enable notifications to make sure they recieve messages in real time. It's similar to how on mobile if your notifications are not enabled, you recieve a prompt to enable them as a part of the onboarding flow. Now the question we have to clarify is if we want to enable 'desktop notifications' through this step or just simply enable 'notifications' for the account or device? Regardless, we probably need to clarify through the copy.

gaelledel commented 2 months ago

Reviewed : we should change the title to "Turn on desktop notifications" and when the user presses on the CTA "enable desktop notifications" we should mark it as Checked regardless if you have changed anything in the toggles or not.

t3chguy commented 2 months ago

@gaelledel maybe the CTA should become Open settings so the user knows clicking it won't perform the enablement immediately so they are more happy to click it to complete the task.

Currently clicking the CTA will ask your browser for permissions to notify, where you'll be met with a browser pop-up. You won't see the settings>notifications page so no toggles involved.

gaelledel commented 2 months ago

@t3chguy Yes to change the string button to "Open settings". Can we have the task marked as complete when the settings window is opened right after enabling permissions via the browser dialog. This should mark the "Turn on notification" task as complete without the need to activate toggles. If the user doesn't allow Notifs to be turned in the Browser Permissions dialog then the task should remain as Unchecked as the settings window will not open in this case. The settings window opening acts as an activator for the task to be marked as checked.

gaelledel commented 2 months ago

Is this issue a good candidate for a maintainer task?

t3chguy commented 2 months ago

Yeah it should be <1h of work