"@room" tags do not render anymore

mcclure commented 9 months ago

Steps to reproduce

The "@‍room" tag, messaging everyone in the room, no longer shows up as a "tag" for me in Browser Element. It is just the word "@‍room". I believe this is a bug because it is a regression (it used to work, as recently as 2 months ago) and because in other clients the same "@‍room" instances show up as a tag.

Outcome

What did you expect?

I expect that if someone has room-notify permissions "@‍room" will appear in a special way, such as in an oval, to show it is a mention. I expect that if someone does NOT have these permissions, it will show up as just the text "@‍room". Thus, to me "@‍room" rendering special or not is an important signal because it shows whether or not the notify-all worked¹.

So for example this is what a friend of mine sees in Element for Linux (Flatpak, Element version: 1.11.50, Olm 3.2.15). This is my "expected behavior".

When I look in the Element Android client I see essentially the same.

What happened instead?

This is what I see in browser:

This screenshot was taken on the same account as the Android version which worked. Reloading the page did not change the appearance.

¹ It was a little inconvenient, I moderate a bimonthly meeting where I need to announce the beginning by typing "@‍room", it didn't seem to do anything, so while trying to ask others if it was working I typed "@‍room" several more times and now I think I was spamming people with messages.

Note: In the interest of not spamming the Github user named "Room" I have inserted zero-width spaces into all instances of "@‍room" in this message.

Operating system

Windows 10 with Chrome 119.0.6045.159 AND Linux Ubuntu 23.10 with Firefox 119.0 Snap

Browser information

-

URL for webapp

https://app.element.io/

Application version

Element version: 1.11.51 Crypto version: Olm 3.2.15

Homeserver

:matrix.org . I am uncertain how to tell what server a particular "room" is hosted on.

Will you send logs?

Yes

mcclure commented 9 months ago

I submitted logs

t3chguy commented 9 months ago

I cannot see any logs from you. Please provide a screenshot showing the permissions for the room, and the event JSON for the event with the @room text in your original screenshot

jjj333-p commented 9 months ago

I can provide said info in a different room, as seen on the current app.element.io

example in chat from my end:

as you can see I am administrator, pl 100, but also screenshot of pl settings:

and the json event:

{
  "type": "m.room.message",
  "sender": "@jjj333_p_1325:envs.net",
  "content": {
    "msgtype": "m.text",
    "body": "@room test",
    "m.mentions": {}
  },
  "origin_server_ts": 1702320679027,
  "unsigned": {
    "age": 628,
    "transaction_id": "m1702320678526.59"
  },
  "event_id": "$_NmaqDTT8fmm_3DRNYQu5wyVh1M6BPvsWacOp4uDFgM",
  "room_id": "!odwJFwanVTgIblSUtg:matrix.org"
}

looking at the json it is strange that it doesnt have room in the mentions field.

t3chguy commented 9 months ago

I cannot reproduce it

jjj333-p commented 9 months ago

Mine was on the latest app.element.io is that what you’re using?

On Tue, Dec 12, 2023 at 6:38 AM Michael Telatynski @.***> wrote:

image.png (view on web) https://github.com/element-hq/element-web/assets/2403652/7ec4f6a0-22b0-4f30-9fe1-f17bde778b41

I cannot reproduce it

— Reply to this email directly, view it on GitHub https://github.com/element-hq/element-web/issues/26719#issuecomment-1852403612, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWNJYMBTYSADUYBKERJVHFDYJCCAJAVCNFSM6AAAAABANDM27KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSGQYDGNRRGI . You are receiving this because you commented.Message ID: @.***>

mcclure commented 9 months ago

I cannot see any logs from you. Please provide a screenshot showing the permissions for the room, and the event JSON for the event with the @room text in your original screenshot

Here is the json for one such event:

{
  "room_id": "[[redacted]]:matrix.org",
  "type": "m.room.message",
  "content": {
    "msgtype": "m.text",
    "body": "@room ",
    "m.mentions": {
      "room": true
    }
  }
}

t3chguy commented 9 months ago

Mine was on the latest app.element.io is that what you’re using?

I was using Element Nightly

bmarty commented 9 months ago

I can repro on https://develop.element.io after a F5:

in a DM
in a room where I am an admin

It's OK in the composer:

Source of those Events:

{
  "content": {
    "body": "@room sent from ea",
    "msgtype": "m.text"
  },
  "origin_server_ts": 1703063474104,
  "sender": "@benoit.marty:matrix.org",
  "type": "m.room.message",
  "unsigned": {
    "age": 420586
  },
  "event_id": "$XXX",
  "room_id": "!XXX:matrix.org"
}

{
  "content": {
    "body": "@room sent from Web",
    "m.mentions": {
      "room": true
    },
    "msgtype": "m.text"
  },
  "origin_server_ts": 1703063486340,
  "sender": "@benoit.marty:matrix.org",
  "type": "m.room.message",
  "unsigned": {
    "age": 408399,
    "transaction_id": "m1703063486241.669"
  },
  "event_id": "$XXX",
  "room_id": "!XXX:matrix.org"
}

So the regression is probably related to the new m.mentions field.

devosonder commented 8 months ago

This problem still persists. Join a room at https://develop.element.io/ or https://app.element.io/ and send a mention with @room. You will see that it does not work. @t3chguy

Microsoft Edge Version 120.0.2210.91 (Official build) (64-bit)

OS: Windows 11