search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11k stars 1.95k forks source link

Enable no floating promises rule #27064

Open dbkr opened 6 months ago

dbkr commented 6 months ago

In a quick discussion, we seems broadly in favour of enabling https://typescript-eslint.io/rules/no-floating-promises/ which mandates that promises returned from functions don't get discarded without being awaited on at some point. This will mean a few fixups to our codebase where we do deliberately not await on functions that are async because they need to do async stuff but we don't care about the result.

t3chguy commented 3 months ago

This results in ~7k errors even with test files excluded