Binary settings choice with inconsistent interaction pattern

element-hq / element-web

A glossy Matrix collaboration client for the web.

https://element.io

Apache License 2.0

10.85k stars 1.92k forks source link

Binary settings choice with inconsistent interaction pattern #27193

Open kongo09 opened 4 months ago

kongo09 commented 4 months ago

Steps to reproduce

Go to settings
Observe a binary setting choice

Outcome

What did you expect?

Always the same pattern, i.e. either a toggle or a checkbox

What happened instead?

Sometimes toggles, sometimes checkboxes

Operating system

Windows 11

Application version

Element version: 1.11.61 Crypto version: Olm 3.2.15

How did you install the app?

No response

Homeserver

element.io

Will you send logs?

robintown commented 3 months ago

This is another issue that would most likely be addressed by the redesign of settings described in https://github.com/element-hq/element-web/issues/27180#issuecomment-2004370784

daniellekirkwood commented 3 months ago

Agree with @robintown I've added this item to the list WRT the Settings update project.

daniellekirkwood commented 2 months ago

@kongo09 I suggest that we close this issue as it will be handled with the Settings redesign.

If you disagree, feel free to reopen this task.

kongo09 commented 2 months ago

Settings redesign currently still has two patterns for the same binary choice, e.g. in notifications.

gaelledel commented 3 weeks ago

Indeed this should be redesigned as part of the settings work we're doing. There might be a reasoning to explain why we use different components. @americanrefugee I'll leave you to review this if needed.

americanrefugee commented 3 weeks ago

There are only a few places we're using checkboxes:

Notifications > Email summary: Multi-select list of emails
Sidebar > Spaces to show > Home: "Show all rooms" is a modifier of the binary option
Security & Privacy > Privacy settings > How to find you: Multi-select list of emails

Otherwise all binary options are indeed a toggle. The only actual exception being the checkbox for "Show all rooms", which was so that primary option and the modifier felt more connected.