search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
Apache License 2.0
10.69k stars 1.88k forks source link

Fix `element-desktop-ssoid being` included in OIDC Authorization call #27431

Closed t3chguy closed 5 days ago

t3chguy commented 2 weeks ago

Requires https://github.com/matrix-org/matrix-react-sdk/pull/12495 Requires https://github.com/element-hq/element-desktop/pull/1662

richvdh commented 1 week ago

[I don't think I really meant to give this a green tick yet; I'd like to hear your thoughts on a separate method first. But if you want to go ahead and merge as-is, that's ok]

t3chguy commented 1 week ago

[I don't think I really meant to give this a green tick yet; I'd like to hear your thoughts on a separate method first. But if you want to go ahead and merge as-is, that's ok]

Yeah separate method is a good call, just come out of an Auth meeting where the legacy and OIDC flows diverged even more so good timing.