Behaviour when trying to DM a federated user on a server with federation disabled is awful - Githubissues

element-hq / element-web

A glossy Matrix collaboration client for the web.

https://element.io

Apache License 2.0

10.74k stars 1.89k forks source link

Behaviour when trying to DM a federated user on a server with federation disabled is awful #27438

Closed ara4n closed 3 weeks ago

ara4n commented 3 weeks ago

Steps to reproduce

Logged into the OIDC test lab
Tried to DM myself on matrix.org (see also https://github.com/element-hq/element-web/issues/27437)
Got an ambiguous "failed" error in the proto DM.
Tried again, which created a new proto DM.
Restarted the app
Now have two proto-dms in the room list, which provide a 'join' button.
Hitting the join button produces a fugly error complaining about trying to call /join on a local+... room ID.

Outcome

What did you expect?

Reasons why I can't send messages should be shown to the user in the nice red warning error, so the user knows what's going on.
Failed proto-DMs should be reused when trying to contact the same user
Failed proto-DMs should not switch to showing a 'join' button which doesn't work, when you refresh

What happened instead?

The error from the server ({errcode: "M_FORBIDDEN", error: "Federation denied with matrix.org."}) was swallowed entirely by the UI.
I ended up with multiple broken DMs to the same user
They ended up giving me useless buggy 'join' buttons

Operating system

No response

Browser information

No response

URL for webapp

https://pr12370--matrix-react-sdk.netlify.app/

Application version

No response

Homeserver

No response

Will you send logs?

No

t3chguy commented 3 weeks ago

Duplicate of https://github.com/element-hq/element-web/issues/24991