search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.19k stars 2k forks source link

Visually broken 'remove alias' button #27985

Closed dbkr closed 1 week ago

dbkr commented 2 months ago

Steps to reproduce

  1. Find a room where you have admin
  2. Open settings
  3. Add a local alias if it doesn't already have one
  4. See: Screenshot 2024-09-02 at 10 11 19

Outcome

What did you expect?

Something that looks like a delete button

What happened instead?

An 'x' and a separate tiny red blob

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

jenish064 commented 2 months ago

Hi @dbkr, I would like to work on this issue but new to matrix.org. Can you please elaborate on how do I find room with an admin (mentioned in step 1).

dbkr commented 2 months ago

If you create a room, you'll have admin in it.

Dev-Gurjar commented 2 weeks ago

241019_05h25m47s_screenshot

I fixed it. What should I do now? Should I send the pull request?

Dev-Gurjar commented 2 weeks ago

the size of the button has to be big otherwise the button for closing room settings will get broken.

trying to attach the changes - d0faf72a09b2d2295466bf93887d2b4edf80ba25

florianduros commented 2 weeks ago

@Dev-Gurjar Yes, you should open a pull request. More information in the contributing guide.

florianduros commented 1 week ago

Fixed in https://github.com/element-hq/element-web/issues/27985