Flaky playwright test: `crypto/event-shields.spec.ts: should show correct shields on events sent by devices which have since been deleted`

Error: jsHandle.evaluate: Error: Cannot encrypt event in unconfigured room !wDXBgADKUDbRHIRBhX:localhost

    at RustCrypto.encryptEvent (http://localhost:8080/bundles/94c04cf2a65f14e9f347/771.js:3276:13)
    at MatrixClient.encryptEventIfNeeded (http://localhost:8080/bundles/94c04cf2a65f14e9f347/init.js:9339:30)
    at async MatrixClient.encryptAndSendEvent (http://localhost:8080/bundles/94c04cf2a65f14e9f347/init.js:9271:9)
    at async <anonymous>:260:30
    at RustCrypto.encryptEvent (/home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/http:/localhost:8080/bundles/94c04cf2a65f14e9f347/771.js:3276:13)
    at MatrixClient.encryptEventIfNeeded (/home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/http:/localhost:8080/bundles/94c04cf2a65f14e9f347/init.js:9339:30)
    at async MatrixClient.encryptAndSendEvent (/home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/http:/localhost:8080/bundles/94c04cf2a65f14e9f347/init.js:9271:9)
    at /home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/async <anonymous>:260:30
    at Bot.sendMessage (/home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/playwright/pages/client.ts:125:23)
    at /home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/playwright/e2e/crypto/event-shields.spec.ts:276:13

ie. the bot client is failing to send a message into the room because it's not ready yet, so probably needs more waiting on the bot side?

RiotRobot commented 1 month ago

https://github.com/element-hq/matrix-react-sdk/actions/runs/11360236274

richvdh commented 1 month ago

ugh.

  3) crypto/event-shields.spec.ts:273:13 › Cryptography › event shields › should show correct shields on events sent by devices which have since been deleted 
    Error: Timed out 5000ms waiting for expect(locator).not.toBeVisible()

    Locator: locator('.mx_EventTile').filter({ hasText: 'test encrypted from verified' }).locator('.mx_EventTile_e2eIcon')
    Expected: not visible
    Received: visible
    Call log:
      - expect.not.toBeVisible with timeout 5000ms
      - waiting for locator('.mx_EventTile').filter({ hasText: 'test encrypted from verified' }).locator('.mx_EventTile_e2eIcon')
      -   locator resolved to <div tabindex="0" aria-labelledby="floating-ui-248" aria-label="State of the end-to-end encryption" class="mx_EventTile_e2eIcon mx_EventTile_e2eIcon_warning"></div>
      -   unexpected value "visible"
      -   locator resolved to <div tabindex="0" aria-labelledby="floating-ui-248" aria-label="State of the end-to-end encryption" class="mx_EventTile_e2eIcon mx_EventTile_e2eIcon_warning"></div>
      -   unexpected value "visible"
      -   locator resolved to <div tabindex="0" aria-labelledby="floating-ui-248" aria-label="State of the end-to-end encryption" class="mx_EventTile_e2eIcon mx_EventTile_e2eIcon_warning"></div>
      -   unexpected value "visible"
      -   locator resolved to <div tabindex="0" aria-labelledby="floating-ui-248" aria-label="State of the end-to-end encryption" class="mx_EventTile_e2eIcon mx_EventTile_e2eIcon_warning"></div>
      -   unexpected value "visible"
      -   locator resolved to <div tabindex="0" aria-labelledby="floating-ui-248" aria-label="State of the end-to-end encryption" class="mx_EventTile_e2eIcon mx_EventTile_e2eIcon_warning"></div>
      -   unexpected value "visible"
      -   locator resolved to <div tabindex="0" aria-labelledby="floating-ui-248" aria-label="State of the end-to-end encryption" class="mx_EventTile_e2eIcon mx_EventTile_e2eIcon_warning"></div>
      -   unexpected value "visible"
      -   locator resolved to <div tabindex="0" aria-labelledby="floating-ui-248" aria-label="State of the end-to-end encryption" class="mx_EventTile_e2eIcon mx_EventTile_e2eIcon_warning"></div>
      -   unexpected value "visible"
      -   locator resolved to <div tabindex="0" aria-labelledby="floating-ui-248" aria-label="State of the end-to-end encryption" class="mx_EventTile_e2eIcon mx_EventTile_e2eIcon_warning"></div>
      -   unexpected value "visible"
      -   locator resolved to <div tabindex="0" aria-labelledby="floating-ui-248" aria-label="State of the end-to-end encryption" class="mx_EventTile_e2eIcon mx_EventTile_e2eIcon_warning"></div>
      -   unexpected value "visible"

      306 |
      307 |             const penultimate = page.locator(".mx_EventTile").filter({ hasText: "test encrypted from verified" });
    > 308 |             await expect(penultimate.locator(".mx_EventTile_e2eIcon")).not.toBeVisible();
          |                                                                            ^
      309 |         });
      310 |     });
      311 | });

        at /home/runner/work/matrix-react-sdk/matrix-react-sdk/matrix-react-sdk/playwright/e2e/crypto/event-shields.spec.ts:308:76

It's a different failure mode to before.

RiotRobot commented 1 month ago

https://github.com/element-hq/element-web/actions/runs/11389048513

RiotRobot commented 1 month ago

https://github.com/element-hq/element-web/actions/runs/11437982011

RiotRobot commented 1 month ago

https://github.com/element-hq/element-web/actions/runs/11500478569

RiotRobot commented 3 weeks ago

https://github.com/element-hq/element-web/actions/runs/11556287070

RiotRobot commented 3 weeks ago

https://github.com/element-hq/element-web/actions/runs/11557477002

RiotRobot commented 3 weeks ago