Fix 'remove alias' button in room settings

Dev-Gurjar commented 1 week ago

Checklist

[ ] Tests written for new code (and old code if feasible).
[ ] New or updated public/exported symbols have accurate TSDoc documentation.
[ ] Linter and other CI checks pass.
[x] I have licensed the changes to Element by completing the Contributor License Agreement (CLA).

Closes https://github.com/element-hq/element-web/issues/27985

Before and After Comparison:

Before:	After:

Explanation:

The size of the button had to be increased to prevent the "close room settings" button from breaking. The images above show the difference before and after the changes, with the button's size adjustment ensuring proper functionality and alignment.

Dev-Gurjar commented 1 week ago

this is my first open source contribution please tell me what am i doing wrong?

Dev-Gurjar commented 1 week ago

I have made the change, and this should fix that. changes - 0025ee7

Is it possible to check by myself if all the errors are solved?

florianduros commented 6 days ago

@Dev-Gurjar

Click on View deployment of the e2e test line:

or

The check mark is green in the CI check

Dev-Gurjar commented 5 days ago

is it working now?

element-hq / element-web