search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.17k stars 1.99k forks source link

Enable Element Call by default on release instances #28313

Closed t3chguy closed 3 days ago

t3chguy commented 3 days ago

Update button label to say it is a Beta

For https://github.com/element-hq/element-internal/issues/638

neilisfragile commented 3 days ago

Channelling @kongo09 (and @daniellekirkwood) This change has Product sign-off.

RiotRobot commented 3 days ago

The backport to staging failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-staging staging
# Navigate to the new working tree
cd .worktrees/backport-staging
# Create a new branch
git switch --create backport-28313-to-staging
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 79c956388f4b4e0feb15d6bc9c4ceabcfb7b9839
# Push it to GitHub
git push --set-upstream origin backport-28313-to-staging
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-staging

Then, create a pull request where the base branch is staging and the compare/head branch is backport-28313-to-staging.

daniellekirkwood commented 2 days ago

Thanks @neilisfragile -- is it possible to get click tracking added for these buttons? It would be awesome to understand if we need to do more education on it or if people grok the selection really quickly... @t3chguy would you be able to add this? Should I write a ticket for you?

t3chguy commented 2 days ago

Not possible for tomorrow only for the release after if it is reviewed in time (unlikely given time constraints) so it'd be for the release after that (Nov 19th). Due to the repo merge we can't make matrix-react-sdk changes for the off cycle.

neilisfragile commented 2 days ago

Off topic, but another option for the future if the buttons are too confusing is to have a single button and have EW make both legacy and MatrixRTC calls in parallel, if either call is accepted then the other one can be hung up.

I think this idea still needs some thinking about how to handle races etc, but mentioning here for context as an alternative option if the two button approach is detrimental.

t3chguy commented 2 days ago

@neilisfragile not sure that'd help with the Jitsi vs Element Call variant of the problem

neilisfragile commented 2 days ago

Yeah agreed, only helps for 1:1 calling