Fix matrix-widget-api version in package.json

element-hq / element-web

A glossy Matrix collaboration client for the web.

https://element.io

GNU Affero General Public License v3.0

11.25k stars 2.01k forks source link

Fix matrix-widget-api version in package.json #28453

Closed AndrewFerr closed 1 week ago

AndrewFerr commented 1 week ago

matrix-js-sdk#develop now depends on matrix-widget-api^v1.10.0, so update the lockfile to match that. A yarn install would update the lockfile otherwise.

The correct version was reverted by element-hq/element-web#28430.

Signed-off-by: Andrew Ferrazzutti andrewf@element.io

Checklist

[ ] Tests written for new code (and old code if feasible).
[ ] New or updated public/exported symbols have accurate TSDoc documentation.
[ ] Linter and other CI checks pass.
[x] I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

MidhunSureshR commented 1 week ago

I'm a bit confused here; are you saying that if I git pull develop and do yarn install, yarn.lock would get updated?

AndrewFerr commented 1 week ago

I'm a bit confused here; are you saying that if I git pull develop and do yarn install, yarn.lock would get updated?

Yes, exactly.

MidhunSureshR commented 1 week ago

That doesn't happen for me. Also the CI would have failed if yarn.lock was modified?

AndrewFerr commented 1 week ago

Interesting, the lockfile was getting updated for me when I filed this, but not anymore. I updated the commit message to reflect that.

I'm not sure if CI fails on lockfiles getting modified, but workflows do tend to use yarn install --frozen-lockfile if that helps.