Show the correct shield status in tooltip for more conditions

element-hq / element-web

A glossy Matrix collaboration client for the web.

https://element.io

GNU Affero General Public License v3.0

11.24k stars 2.01k forks source link

Show the correct shield status in tooltip for more conditions #28476

Open uhoreg opened 6 days ago

uhoreg commented 6 days ago

Depends on https://github.com/matrix-org/matrix-js-sdk/pull/4529 Fixes https://github.com/element-hq/element-web/issues/28170

Checklist

[ ] Tests written for new code (and old code if feasible).
[ ] New or updated public/exported symbols have accurate TSDoc documentation.
[ ] Linter and other CI checks pass.
[ ] I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

uhoreg commented 6 days ago

I think that this will need some trickery to merge this with the JS side. Obviously, this can't be merged until the JS PR is merged, since it uses values defined in that PR. But I think that when the JS side gets merged, then TypeScript will complain because the switch statement doesn't cover all cases. I think that one way to fix it is to add an Element PR that adds a default clause to the switch statement, merge that, then merge the JS PR, and then merge this PR.