search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.24k stars 2k forks source link

Typing two keys quickly in spotlight dialog closes the dialog #28493

Open david-crespo opened 3 hours ago

david-crespo commented 3 hours ago

Steps to reproduce

After upgrading to 1.11.86:

  1. Press cmd-k to open room quick search
  2. Type any two keys quickly

I was able to confirm that downgrading to 1.11.85 fixes the issue.

Outcome

What did you expect?

I expect the search dialog to stay open and the input field shows the two keys I pressed.

What happened instead?

The dialog closes, and the message input is focused instead. This means that if I type, for example, three keys and press enter, the first two go into the room quick search and the third + enter go into the message box. I have been sending a lot of one-letter messages today.

https://github.com/user-attachments/assets/7234a53c-ef72-4737-89f8-f223599ebdad

Operating system

macOS

Application version

1.11.86

How did you install the app?

https://element.io/app-for-productivity, but that was a long time ago. This was just an in-app upgrade.

Homeserver

https://matrix.oxide.computer

Will you send logs?

Yes

david-crespo commented 3 hours ago

I'm only a simple country web developer, but https://github.com/element-hq/element-web/pull/28452 from last week changes the node that gets focused on various events in the spotlight dialog.

t3chguy commented 30 minutes ago

I'm only a simple country web developer, but https://github.com/element-hq/element-web/pull/28452 from last week changes the node that gets focused on various events in the spotlight dialog.

This PR is not included in 1.11.86 as it was merged after the RC.

@MidhunSureshR you were handling fixing this and believed it to be due to React 18 double-rendering which only affects development builds, this issue claims otherwise, can you confirm?