Persistent stuck notifications and badge count

element-hq / element-web

A glossy Matrix collaboration client for the web.

https://element.io

GNU Affero General Public License v3.0

11.01k stars 1.96k forks source link

Persistent stuck notifications and badge count #3059

Open kegsay opened 7 years ago

kegsay commented 7 years ago

What happened:

I got binged in a room. Riot's favicon went to (1) and the room went to (1).
I clicked the room. I read the message. The (1) disappeared on both.
I swapped to another room. The (1) came back on both favicon and room.
I swapped to the room. It disappeared.
Rinse repeat at least 8 times (enough that I demonstrated this to @lukebarnard1 ).

What I expect to happen:

The (1) should disappear and not come back as I was not binged in that room anymore.

What actually happened:

It kept reappearing. I had to mute the room.

dbkr commented 7 years ago

I've seen behaviour like this when the server is struggling so this is likely to be the HS trying to decide what our notification count should be.

kegsay commented 7 years ago

Do we get any more information other than the notif count for each room? It'd be nice if Riot-Web could say "I've already binged for event ID ABC123, I'm not going to do it again".

ara4n commented 7 years ago

this sounds almost the same as vector-im/element-web#3060?

kegsay commented 7 years ago

Different - This one the notification did go away for a bit, but then returned. vector-im/element-web#3060 seems to never go away until you go to a random room.

turt2live commented 7 years ago

I managed to encounter something similar to this (and by proxy, vector-im/element-web#3060 as well) with some help from vector-im/element-meta#486 (so this might actually be invalid/a different issue):

Set the room to notify on "All Messages (Loud)"
Receive a couple messages when not looking at room
Set the room to "Mentions Only" or lower without going into room
- At this point, the badge next to the room goes away, but the favicon stays stuck
Go into room to clear notification from the favicon
Carry on and go to other rooms and wait for more messages
No badge in room list, favicon gets a nice red mark on it

Edit: Muting the room doesn't help :/

ara4n commented 7 years ago

related to vector-im/element-web#2427

jurf commented 6 years ago

I have a stuck notification too, it’s been like that for ages. Driving me nuts.

grahamperrin commented 6 years ago

@jurf if you sequentially browse every room where you're a member, without bothering to page up or down to tell whether there's the thing that caused the notification, then does the notification disappear?

jurf commented 6 years ago

@grahamperrin I did that once before and it only maybe 1 out of 2 disappear. This time the other one disappeared too. Thanks! (Btw the culprit was the Riot room.)

grahamperrin commented 6 years ago

@jurf thanks for the feedback. (A couple of days ago I submitted, from within Riot, a bug report that might partially explain your most recent incident. Too soon to tell whether that report equates to an existing issue.)

aaronraimist commented 5 years ago

~~May be fixed by https://github.com/matrix-org/matrix-react-sdk/pull/3121~~

Not fixed for me

dreamerchris commented 5 years ago

I got this too in all my clients so it must be something core that makes this one notification count apear

daniellekirkwood commented 1 year ago

Is this issue still a defect you're experiencing?

We think it needs to be closed - it will stay open for now but will be closed next week if we haven't heard anything.

Thanks!

turt2live commented 1 year ago

The slow server case has not been fixed, nor has the switching between notification levels (to my knowledge)