element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.26k stars 2.01k forks source link

make it possible to change font size #3160

Closed IzabellaDK closed 4 years ago

IzabellaDK commented 7 years ago

Being of a somewhat mature age the eyes are not happy with too small fonts. And it feels a bit awkward to sit with a magnifying glass just for reading a comment... So: Please make give me to option to choose the size of typeface in the chatwindow. Would be nice though if everything was a bit more readable for old eyes that have seen so much of the world...

Thx in advance for your effort - and a nice app for all the main platforms!

richvdh commented 7 years ago

Have you tried zooming in?

IzabellaDK commented 7 years ago

With a magnifying glass? :)

IzabellaDK commented 7 years ago

Dark Theme actually helps a bit - but still..

richvdh commented 7 years ago

With a magnifying glass? :)

That, or you could try your browser's zoom controls... ctrl-plus/minus here.

IzabellaDK commented 7 years ago

Ofc it would work in a browser but uses the Riot windows app.

Mag glasses are great but not if you write with 10 fingers at the same time 💃

richvdh commented 7 years ago

Right, the fact you are using the electron app would have been helpful information upfront ;)

ara4n commented 7 years ago

yeah, there's a weird problem here. even if you /do/ use ctrl-plus/minus (or pinch-zoom on macOS) it only remembers it for a single page for some reason.

ara4n commented 7 years ago

have filed the brokenness as #3179. let's keep this bug as tracking exposing the setting more clearly.

IzabellaDK commented 7 years ago

Thx very much!!

Mikaela commented 7 years ago

That, or you could try your browser's zoom controls... ctrl-plus/minus here.

The issue for me is that this isn't remembered and the zoom randomly reverts to original 100%.

I have two use cases:

On my laptop I am able to read all the other apps by adjusting my desktop settings and if Riot is not going to follow them (why?) I would like to have the option like in the other apps.

Appreance Preferences

NessBird commented 7 years ago

It's very upsetting to me that Github Desktop doesn't accommodate older users. I think this should be a priority.

ara4n commented 7 years ago

i believe this was fixed a while back - ctrl-plus and ctrl-minus (or cmd-plus/cmd-minus on a mac) should change the zoom, and i believe it is now remembered when you switch room?

NessBird commented 7 years ago

No, those keys do not do anything. There appears to be no way to zoom. It identifies itself as Deer Types 222. It says an update will be installed when I relaunch, but this did not appear to happen.

NessBird commented 7 years ago

Now I have it up to Things Done Hastily, same behavior.

t3chguy commented 7 years ago

@NessBird wrong repo, those are versions of Github Desktop - this is riot-web. (https://desktop.github.com/release-notes/mac/)

ara4n commented 7 years ago

I think all that is needed here is really to hook up the View: Zoom In/Zoom Out menus in Electron, much as you have in plain old Chrome.

status-open-bounty commented 7 years ago

Current balance: 0.0 ETH Tokens: SNT: 4000.00 Contract address: 0x26e6a832b0a2e6a5fca5f5715a00f520afd2806f QR Code Network: Mainnet To claim this bounty sign up at https://openbounty.status.im and make sure to update your Ethereum address in My Payment Details so that the bounty is correctly allocated. To fund it, send ETH or ERC20/ERC223 tokens to the contract address.

monokh commented 6 years ago

Hi i'd like to work on this but a little confused on the requirements. From my testing (mac OSX) Ctrl +, Ctrl - work just fine. It applies in the same session although not the next time you launch riot. It seems that electron has actually remembered the zoom level but not applied it, because if you zoom (ctrl +) you will be back to the zoom level you had previously.

So is the main idea to preserve the zoom level across different sessions?

IzabellaDK commented 6 years ago

Well - the problem persists when using Riot in Windows 10 and Ubuntu 17.xx since no shortcuts are working to increase/decrease font size in these environments - and it is not possible to change font in settings

t3chguy commented 6 years ago

Better would be to add a font size slider like discord has

monokh commented 6 years ago

Ok understood. Is this setting to be visible on both desktop and web or will this be a "desktop specific" setting that changes the electron window zoom level (given that the problem is not applicable in web)? I imagine having the setting work uniformly across desktop and web may be a bit more challenging.

monokh commented 6 years ago

@IzabellaDK i've just got windows running now and tested zoom. I can to zoom with the following combinations: Zoom Out (Ctrl -) Zoom in (Ctrl Shift +) Can anyone confirm if this works on their side? It's less than ideal but it narrows down the root problem.

IzabellaDK commented 6 years ago

Does not work in this build of W10: 17046 - which is an rs_prerelease version

IzabellaDK commented 6 years ago

I only use Riot in desktop versions on Windows, Ubuntu (soon to be changed to another dist) and Android

monokh commented 6 years ago

I've also tested this on ubuntu now and the same shortcuts as windows apply: Zoom Out (Ctrl -) Zoom In (Ctrl Shift +) In windows, this is displayed in the menu accordingly as well (Alt + view). Do you see these shortcuts in your version of windows?

If the issue is with very specific versions of OS, it is highly likely an issue in electron and should be fixed there. The zooming feature works pretty well from what I've tested and I think introducing an option for zoom separately that works across devices and versions will be more difficult and less maintainable compared to keeping up with the electron implementation of this.

I have a fix for changing the Zoom In shortcut to <Ctrl +> on windows and ubuntu, let me know if this would help.

IzabellaDK commented 6 years ago

It works now when using the keys on keyboard - not the numbers part.

So from here I would call this problem solved: Thank you very much!!

t3chguy commented 6 years ago

The app (and site) still needs a font control setting, to be user friendly

monokh commented 6 years ago

@t3chguy made an initial stab at implementing the setting 😃 will refine it soon. Let me know if any concerns

monokh commented 6 years ago

The pull request open (https://github.com/matrix-org/matrix-react-sdk/pull/1651) for adding this setting is ready now. Let me know if something different/more advanced is needed.

uhoreg commented 6 years ago

I just found out that you can start the desktop app with --force-device-scale-factor={decimal} (where {decimal} is a decimal number) to scale things. Obviously, this isn't a replacement for a proper UI, but maybe can help some people until it is fixed.

aaronraimist commented 6 years ago

It seems like in v0.17.0 (haven't tested earlier versions) zooming out and resetting the room (ctrl +0) are hooked up but not zooming in.

pavi commented 6 years ago

In the new design will there be option to scale up the interface. It would be nice to have the scaling implemented like in telegram where the whole interface scales up organically. If this is left up to the browser the browser can scale as it likes without much control.

The example of such scaling option is given above at https://github.com/vector-im/riot-web/issues/3160#issuecomment-316148333

rubo77 commented 6 years ago

On Ubuntu 18.04 with riot-web 0.17.0 the zoom factor is remembered until riot is completely exited.

On each first start the Zoom is reset to 100%

If you don't find the zoom, press ALT once and you get the menu on top which has View->Zoom in and out

You can also zoom via shortcuts:

(This seems a bug, because the menu sais CTRL +, maybe this bug only exists in german QWERTZ keyboardlayout)

see #7696

A sentence in the settings

Use CTRL + and - keyt to zoom

would be great though!

t3chguy commented 6 years ago

@rubo77 yes but typically the =+ key requires the shift modifier to be + as opposed to =

rubo77 commented 6 years ago

In the german QWERTZ Keyboard layout the + key is reacheable without SHIFT, so this IS a bug!

t3chguy commented 6 years ago

This is an electron bug then as it is what adds that behaviour

rubo77 commented 6 years ago

So #7696 was not the right place to post this?

kascana commented 5 years ago

As other users have suggested above, it would be much more user-friendly to have the ability to change the font size easily. Users with poorer eyesight and particularly elder people would have difficulties to modify the font size, if this setting is hard to find and not directly visible. Ctrl+/- is helpful for scaling the fonts and icons, but in my opinion it will be much better to have the option to increase and decrease the font size internally. I appeal to have the possibility to change the font size and also to select a dark or bright theme directly from the main panel, preferably by just one click. A nice solution would be to have a slider or a dedicated icon in the top right corner with a functionality similar to the one visible in the following image: ereader prestigio style settings

pravi commented 5 years ago

I opened #8416 as it was working earlier but stopped working now.

davidbarratt commented 5 years ago

Atom allows you to zoom the entire interface (just like the browser) and that works well, so I'd like something like that.

kascana commented 5 years ago

The point is not to zoom the entire interface, but only to increase or decrease easily the font size of the written messages. The issue is even bigger for people using various scripts (other than Latin), when it can be desirable to have a bigger or smaller font size. Any e-book reader and text-orientated program has this basic functionality. I can only hope that in the interest of many users this will be implemented soon. Of course, zooming the entire intefcace with ctrl +/- should work as well, but this is a different matter.

aaronraimist commented 5 years ago

(@davidbarratt @kascana zooming the entire interface with ctrl +/- should work, if it doesn't file a separate issue)

davidbarratt commented 5 years ago

(@davidbarratt @kascana zooming the entire interface with ctrl +/- should work, if it doesn't file a separate issue)

It does not work. :(

kascana commented 5 years ago

(@davidbarratt @kascana zooming the entire interface with ctrl +/- should work, if it doesn't file a separate issue)

It does not work. :(

It does work on a Windows desktop riot version (at least), but I don't see how one can easily modify the font size without changing the entire interface. This is in my view a big must in programs like this.

aaronraimist commented 5 years ago

@kascana yes that is what this issue is for

@davidbarratt please file a separate issue

ordinarygulp commented 5 years ago

Looking forward to this, and also experiencing #9533

PeterKassab commented 5 years ago

It would be great to have this option, this option is present in most development tools. Just like the Dark theme.

PeterKassab commented 5 years ago

Hey guys, this option already exists, try View + Zoom in or Ctrl + =

Good work.

t3chguy commented 5 years ago

That's zoom, changes the scale of everything, not just the font

kascana commented 5 years ago

Indeed, Ctrl +/- scales everything and is not always a practical solution, especially when someone is using different scripts/languages for writing messages. It would be much better to be able to modify the size of the text indepentently of the interface. I can only refer one more time to my suggestion and the attached example from January 5. Is it so difficult to implement such a basic functionality?