Closed richvdh closed 9 months ago
+1 pour le #301 (Next unread room)
Sorry to bug but:
ctrl-k to jump to named room does not work in macOsx native app or on chrome
up/down up/down does not seem to work
@frankiebee I believe on Mac it is Cmd+k
that does not work either
What about pretty standard feature β Enter
for newline, Ctrl-Enter
for send?
And another hotkey-related request. I's really useful to close all chats to keep all messages unread. Currently it can be done with Home
button in the bottom of left menu.
Will it be nice to have hotkey for this? For example Telegram uses ESC
for this β very convenient and expectable.
@anton-ryzhov more commonly its Shift-Enter
for newline and Enter
for send.
@t3chguy Definitely it should be configurable.
@anton-ryzhov it's down to your browser how it handles input boxes
The Ctrl+K
shortcut does not work for me either in WebKitGTK+ based browsers (or in Revolt, which also uses it).
Ctrl+K
was removed while a PR undergoes testing, it will be added back when it is tested. https://github.com/matrix-org/matrix-react-sdk/pull/895
@t3chguy
it's down to your browser how it handles input boxes
What do you mean? It is a
Depends, it can also be a contenteditable div.
<div aria-describedby="placeholder-1soc8" class="public-DraftEditor-content" contenteditable="true" role="textbox" spellcheck="true" style="outline: none; white-space: pre-wrap; word-wrap: break-word;"><div data-contents="true"><div data-block="true" data-editor="1soc8" data-offset-key="2cmcm-0-0"><div data-offset-key="2cmcm-0-0" class="public-DraftStyleDefault-block public-DraftStyleDefault-ltr"><span data-offset-key="2cmcm-0-0"><br data-text="true"></span></div></div></div></div>
but yes the handling could be defined in riot, feel free to contribute a PR
Adding to the list :-)
Ctrl+Home
/ Ctrl+End
to jump to beginning or end of multiline text input in the Composer. "Like in normal editors."Ctrl+PageUp
/ Ctrl+PageDown
to jump to beginning / end of the main scrollpanel. Currently assigned to Ctrl+Home
/ Ctrl+End
but needs a new binding if implementing the task just above. PageUp
/ PageDown
currently scrolls through the main scrollpanel, so the new proposal seems a good fit to me.Edit: Forget these. I just saw in riot.im/develop/ (with the "New Composer" enabled) that the Up
and Down
arrow buttons will now move the caret to the very beginning / very end when in the first / last line, respectively. So one can simply keep them pressed until at the very first / last character. Since chat messages are just a few lines, that's perfectly fine.
Enter
for newline, Ctrl-Enter
for send would definitely be nice, I prefer this way.
It would be nice to Bind the shortcuts for yourself, for example on mouse buttons, and so on.
@coreinsane I presume you mean on electron app as mouse buttons tend to be bound at browser level
Yes you got the point, im using windows desktop client.
Is there any improvement on windows desktop client hotkey features? Like customisable hotkeys, can be bound on mouse, etc.
It would be nice to add some more hotkeys related to the infinite scrolling functionality of the room timeline because hotkeys such as ctrl+home, ctrl+end, pageup and page down are usually clashing with standard browser keyboard commands when caret browsing is turned on (e.g. by pressing F7 in Firefox). I would like to have at least shortcuts for scrolling to the bottom and then scroll to prev / next page.
Are Riot hotkeys documented somewhere permanently?
@eatonphil I started documenting them here https://github.com/vector-im/riot-web/pull/7165
I would like to suggest another one that might be useful:
ctrl + alt + (up or down) - Navigate between your community filters on the left nav. This is similar to what happens in Discord to switch between guilds.
All of these shortcuts should be configurable. Please do not create a jumble of hardcoded key combos.
tab/shift-tab to navigate focus as normal (other than in MessageComposer, where it tab-completes)
How does one jump out of MessageComposer then? Once you're there, there doesn't appear to be a way out.
How does one jump out of MessageComposer then? Once you're there, there doesn't appear to be a way out.
The plan is to stop trapping tab there
How about a shortcut for jumping to the first unread message?
@foresto #301
301
That one is for jumping to another room with unread messages. I'm talking about jumping to the first unread message in the current room.
When I change to another browser tab for a while, or walk away from my computer and then come back, there are sometimes a bunch of new messages in current room. It would be nice not to have to manually scroll back and read every message in reverse just to find the point where I left off.
@foresto sorry, I should've read more carefully
I literally daily try to do ctrl+tab
to switch between two rooms, like I can switch between two tabs in my Firefox. Of course it wouldn't really work for riot-web but would be awesome for the desktop version :thinking:
Right now that's alt up-down, we could add that for electron. Upvote the comment if desired.
Right now that's alt up-down
That iterates the room list up/down though, which is useful but not entirely the same thing. Some apps like Chrome I believe also iterate tabs on ctrl-tab. But often the behaviour is to cycle between the last used ones, so that you can for example switch between two rooms back and forth, even if your room list is 100. This is common I believe in many text editors but Firefox also has it, though I believe it needs to be separately enabled AFAICR.
Of course alt up/down works if the rooms one is cycling are relatively close to each other in the room list.
That's #6384 then
* ctrl-k to jump to named room does not work in macOsx native app or on chrome
Ctrl-K does not work on Riot desktop for linux, either.
Ctrl-K does not work on Riot desktop for linux, either.
@foresto It definitely should work, the comment you referred to is from 2017. Running Riot Desktop on Ubuntu myself.
Possibly something is conflicting with it in your setup? I would suggest logging a new issue with more details on linux desktop flavour, window manager, and such? And obviously checking first if you have some custom shortcuts added that conflict with it.
@foresto
Ctrl-K does not work on Riot desktop for linux, either.
Do you have the left panel collapsed, is the Explore button visible?
@t3chguy
Do you have the left panel collapsed
Yes, I have it semi-collapsed, so only the room icons are visible. I tried it just now with the left panel expanded, and Ctrl-K worked in that case. (Doesn't do me any good, though, since an expanded left panel wastes too much space.)
Now it'll work even when collapsed
Confirmed: Ctrl-K now works when the left panel is collapsed. (Thanks, @t3chguy !) However, it also expands the panel and leaves it expanded, dominating the window and pushing the chat area into a narrow column. I end up having to pick up the mouse to fix this, so it ends up no more helpful than it was when it didn't work.
However, alt-up/down seems to work now, which is handy. :)
Ctrl+F would be great for search. Lots of muscle memory from browser etc.
That's #2764
I'd propose remapping CTRL+K to markdown links and "current room search" as ctrl+shift+f(which would IMHO make more sense when "serach in room" is CTRL + f ). My muscle memory from other editors(github, tyora, obsidian, marktext) is pretty useless in that regard currently.
CTRL+K
is already jump to room in other chat apps so for consistency it makes sense to keep it as such, see Discord and Slack
Since you're mentioning Slack and Discord, why not CTRL+shift+U? :stuck_out_tongue:
Riot:
Discord:
Slack, I don't see Ctrl Shift U in https://slack.com/intl/en-gb/help/articles/201374536-Slack-keyboard-shortcuts#windows-linux-6
Well seems like they've removed it in february this year, according to this answer on SO, and added an automated behaivour instead.
Since you're mentioning Slack and Discord, why not CTRL+shift+U? stuck_out_tongue
At least on GNOME that's already taken.
To enter a character by its code point, press Ctrl+Shift+U, then type the four-character code and press Space or Enter.
(src)
Add keys to open Threads, Pins, Notifications panels.
All of these shortcuts should be configurable. Please do not create a jumble of hardcoded key combos.
This would be seriously helpful as rather than CTRL+Y to redo CTRL+SHIFT+Z is an alternate key combination to perform the same thing in most modern applications depending on the platform.
In addition in one of the latest updates the "Search" icon is now just displaying as "CTRL+K" when the sidebar is collapsed π
What is the policy or thinking of multiple shortcuts for the same action? I prefer to keep my fingers on the home row which makes accessing the arrow keys non-optimal. Shortcuts like Alt+Shift+Down for next unread room are very awkward to type for people used to vim/emacs type bindings.
Ctrl+K is wonderful for jump to room. Would it be possible to get Ctrl+J to "jump" to next unread conversation (Ctrl+Shift+J cycles back in the list.)
Thanks!
We have a few requests for extra hotkeys, but I thought a single issue would be useful to help track them.
So far we have:
Working:
Broken:
We should add hotkeys for
This is related to https://github.com/vector-im/riot-web/issues/302, but I think that's more about tab indexes and making it possible to "click" buttons without a mouse, while this is all about hotkeys that don't require particular elements to be focussed.