search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.14k stars 1.99k forks source link

If inviting a user fails, user is shown a cryptic 'Failure to create room' error. #4062

Open ara4n opened 7 years ago

ara4n commented 7 years ago

I was testing ILAG on my local HS, which is not federated. It tried to invite riot-bot which failed with a 502 (not unreasonably), bubbling up a "Failure to create room" error. However, it then ditched me and didn't let me complete the flow to actually fill in the 'start chat' or 'create room' dialogs.

lukebarnard1 commented 7 years ago

This is expected, the only situation in which you should expect your intention before being a PWLU to be carried forward is when joining

ara4n commented 7 years ago

it's still a very cryptic error though...

lukebarnard1 commented 7 years ago

Agreed, but this is quite orthogonal to ILAG and could be improved for invites in general.

lampholder commented 7 years ago

Can we categorise this as "Failed invites should give better feedback than 'failure to create room' error", or something similar?

lampholder commented 7 years ago

Modifying the title, classifying as a bug and booting out of ILAG.

lampholder commented 7 years ago

P2 minor because (if I understand this correctly) this will only affect people who:

ara4n commented 7 years ago

It is an awful experience for people who are running riot on a new non-fed HS though.

-- Matthew Hodgson Matrix.org

On 1 Jun 2017, at 10:24, Tom Lant notifications@github.com wrote:

P2 minor because (if I understand this correctly) this will only affect people who:

use a riot instance they don't host (and hence can't reconfigure the welcomeUserId setting in config.json) to connect to a home server that can't federate with matrix.org — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

aaronraimist commented 5 years ago

Error message looks like this

screen shot 2018-10-26 at 8 18 50 pm

You also still get an empty room even though the error message is failure to create room...

abeluck commented 5 years ago

It is an awful experience for people who are running riot on a new non-fed HS though. So true :(

This is still present in the redesign branch fwiw.

Edit: And in some ways it is worse in the redesign, after registering, the app hangs with a gray screen and static spinner for upwards of a minute or so, before throwing the error message. Most of my test users just refreshed the page, other thought it was broken.

t3chguy commented 1 year ago

You also still get an empty room even though the error message is failure to create room...

That's https://github.com/matrix-org/synapse/issues/8625 / https://github.com/matrix-org/synapse/issues/8895