element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.2k stars 2k forks source link

roomsetting to strip HTML colours (as bridged from IRC) #5424

Open ara4n opened 7 years ago

ara4n commented 7 years ago

We need to have ability to strip HTML colors, because in some cases it extremely reduces text legibility, see linked issue below. Suggested solution to solve this issue is to add a generic config option, so you can manually turn off irc-like text coloring on demand.

Edited to add details. First issue describing problems: https://github.com/vector-im/element-web/issues/9366

t3chguy commented 7 years ago

+10000000

t3chguy commented 7 years ago

/me adds to 70 issue long todo list

ara4n commented 7 years ago

this is a particularly good candidate for granular settings, too - given you might want to enforce it for a room, or for an account, or even for a device (if devices have different themes).

t3chguy commented 7 years ago

Should this be just font colour attr or also 'data-mx-bg-color', 'data-mx-color' as bridged from IRC implies just the colour attr, but the other two are other ways of sneaking colour in, that won't enter via the bridge

genofire commented 1 year ago

is there away to send different colors for light and dark themes? e.g. for light themes, darkblue and for dark theme lightblue?

this is not readable on an element with dark theme enabled:

<font color="blue">Info</font>
t3chguy commented 1 year ago

No, that is not something the Matrix spec allows @genofire - but it does allow setting a foreground and background colour so you can ensure legibility.

genofire commented 1 year ago

Hmm, should element render "default" colors dedicated by light and dark mode? e.g. send-color: <font color="{{ sendColor}}">Info</font>

send-color light-theme dark-theme comment
red red red always good readable
blue blue lightblue
green darkgreen green
yellow orange yellow
t3chguy commented 1 year ago

that wouldn't work with custom themes, where someone's background might be red or blue or pink or whatever e.g. https://github.com/aaronraimist/element-themes